Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove permissions #609

Closed
wants to merge 1 commit into from
Closed

Remove permissions #609

wants to merge 1 commit into from

Conversation

martincostello
Copy link
Owner

Remove permissions as the default token passed in from the parent workflow should give the appropriate permissions as the token has to be explicitly passed in.

Remove permissions as the default token passed in from the parent workflow should give the appropriate permissions as the token has to be explicitly passed in.
@martincostello martincostello added the enhancement New feature or request label Oct 7, 2023
@martincostello martincostello added this to the v3.0.1 milestone Oct 7, 2023
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a1b94ca) 88.79% compared to head (868a378) 88.79%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #609   +/-   ##
=======================================
  Coverage   88.79%   88.79%           
=======================================
  Files           2        2           
  Lines         348      348           
  Branches       66       66           
=======================================
  Hits          309      309           
  Misses         32       32           
  Partials        7        7           
Flag Coverage Δ
linux 88.79% <ø> (ø)
macos 88.79% <ø> (ø)
windows 88.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello
Copy link
Owner Author

Not sure whether this is working how I think or not - will test manually on Tuesday with the next .NET SDK update.

@martincostello
Copy link
Owner Author

Yeah, doesn't work:

HttpError: Resource not accessible by integration
    at /home/runner/work/_actions/martincostello/update-dotnet-sdk/1ae26d24c0d15d2f17f722c65886ffabff4f826a/webpack:/update-dotnet-sdk/node_modules/@octokit/request/dist-node/index.js:86:1
    at process.debug (node:internal/process/task_queues:95:5)
    at DotNetSdkUpdater.result [as createPullRequest] (/home/runner/work/_actions/martincostello/update-dotnet-sdk/1ae26d24c0d15d2f17f722c65886ffabff4f826a/webpack:/update-dotnet-sdk/lib/DotNetSdkUpdater.js:282:1)
    at DotNetSdkUpdater.tryUpdateSdk (/home/runner/work/_actions/martincostello/update-dotnet-sdk/1ae26d24c0d15d2f17f722c65886ffabff4f826a/webpack:/update-dotnet-sdk/lib/DotNetSdkUpdater.js:236:1)
    at run (/home/runner/work/_actions/martincostello/update-dotnet-sdk/1ae26d24c0d15d2f17f722c65886ffabff4f826a/dist/index.js:1:18302)

@martincostello martincostello deleted the remove-permissions branch October 10, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant