Mark expected as [[nodiscard]] #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it holds either a result or an error (that is, it always might hold an error), an `expected` return value should never be blindly discarded.
martinmoene
added a commit
that referenced
this pull request
Dec 10, 2024
…NODISCARD (#74, thanks Quuxplusone)
martinmoene
added a commit
that referenced
this pull request
Dec 10, 2024
expected.t.cpp(1347): warning C4834: discarding return value of function with 'nodiscard' attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it holds either a result or an error (that is, it always might hold an error), an
expectedreturn value should never be blindly discarded.At least that's my take on it: https://quuxplusone.github.io/blog/2024/12/08/should-expected-be-nodiscard/
boost::outcome_v2::result<T>andllvm::Expected<T>are already marked nodiscard. No vendor'sstd::expectedis marked yet, but the /r/cpp chatter re my above post makes it sound like both STL and jwakely are at least considering it now.IMHO this is a Very Good Idea, but if you as the project owner think it's not (or not yet), then feel free to close it.