Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterator tag is "random access" but doesn't satisfy random access concept #30

Closed
Crzyrndm opened this issue Oct 16, 2023 · 0 comments · Fixed by #31
Closed

Iterator tag is "random access" but doesn't satisfy random access concept #30

Crzyrndm opened this issue Oct 16, 2023 · 0 comments · Fixed by #31

Comments

@Crzyrndm
Copy link
Contributor

Crzyrndm commented Oct 16, 2023 •
edited
Loading

Godbolt. The operator[] definition is missing

Concept definition: https://en.cppreference.com/w/cpp/iterator/random_access_iterator

iterator marked with RA Iterator category tag

Found this while porting some code from SFINAE to concepts. Minor hiccup
@Crzyrndm Crzyrndm mentioned this issue Oct 16, 2023
Merged
martinmoene pushed a commit that referenced this issue Oct 16, 2023
@Crzyrndm @martinmoene
add indexing operators to ring span iterator type (#30, #31, thanks @…
2c6ae83 
…Crzyrndm)
martinmoene pushed a commit that referenced this issue Oct 16, 2023
@Crzyrndm @martinmoene
add operator+(int, iterator) overload (#30, #31, thanks @Crzyrndm)
42cc095
martinmoene added a commit that referenced this issue Oct 16, 2023
@martinmoene
Update Readme.md, section test specification (#30, #31, thanks @Crzyrndm
f4ba7c2 
)
martinmoene added a commit that referenced this issue May 21, 2024
@martinmoene
Document operator+(int, ring_iterator), operator-(int, ring_iterator) (…
d488ce2 
…#30, #31)
martinmoene added a commit that referenced this issue May 21, 2024
@martinmoene
Document operator+(int, ring_iterator), operator-(int, ring_iterator) (…
5ab6850 
…#30, #31)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Iterator additions to match concept std::random_access_iterator
1 participant
@Crzyrndm