Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udev_enumerate_scan_devices() fails with ENOENT because of missing "bus" and "class" folders #144

Closed
dlech opened this issue Sep 10, 2021 · 0 comments · Fixed by #145
Closed

udev_enumerate_scan_devices() fails with ENOENT because of missing "bus" and "class" folders #144

dlech opened this issue Sep 10, 2021 · 0 comments · Fixed by #145

Comments

@dlech
Copy link
Contributor

dlech commented Sep 10, 2021 •
edited
Loading

When using umockdev without loading any devices, udev_enumerate_scan_devices() will return -ENOENT since the "bus" and "class" directories have not been created yet. The current test for this doesn't fail because GUdev ignores the error from this function.
dlech added a commit to dlech/umockdev that referenced this issue Sep 10, 2021
@dlech
Testbed: Create "bus" and "class" dirs at init
0facd0a 
libudev expects the "bus" and "class" directories to exist when calling
udev_enumerate_scan_devices(). When this was called on an empty Testbed,
it would return -ENOENT since these directories did not exist.

This fixes the issue by creating the "/sys/bus" and "/sys/class" at the
same time that "/sys" is created in the Testbed.

num_udev_devices() is modified to call udev_enumerate_scan_devices()
directly instead of using GUdev, which ignores the return value of
udev_enumerate_scan_devices(). This makes t_testbed_empty() a valid
test for the bug we are fixing.

Some vala tests also had to be modified to account for the change.

Fixes: martinpitt#144
dlech added a commit to dlech/umockdev that referenced this issue Sep 10, 2021
@dlech
Testbed: Create "bus" and "class" dirs at init
294449f 
libudev expects the "bus" and "class" directories to exist when calling
udev_enumerate_scan_devices(). When this was called on an empty Testbed,
it would return -ENOENT since these directories did not exist.

This fixes the issue by creating the "/sys/bus" and "/sys/class" at the
same time that "/sys" is created in the Testbed.

num_udev_devices() is modified to call udev_enumerate_scan_devices()
directly instead of using GUdev, which ignores the return value of
udev_enumerate_scan_devices(). This makes t_testbed_empty() a valid
test for the bug we are fixing.

Some vala tests also had to be modified to account for the change.

Fixes: martinpitt#144
@dlech dlech mentioned this issue Sep 10, 2021
Merged
martinpitt pushed a commit that referenced this issue Sep 11, 2021
@dlech
Testbed: Create "bus" and "class" dirs at init (#145)
5e82960 
libudev expects the "bus" and "class" directories to exist when calling
udev_enumerate_scan_devices(). When this was called on an empty Testbed,
it would return -ENOENT since these directories did not exist.

This fixes the issue by creating the "/sys/bus" and "/sys/class" at the
same time that "/sys" is created in the Testbed.

num_udev_devices() is modified to call udev_enumerate_scan_devices()
directly instead of using GUdev, which ignores the return value of
udev_enumerate_scan_devices(). This makes t_testbed_empty() a valid
test for the bug we are fixing.

Some vala tests also had to be modified to account for the change.

Fixes #144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Testbed: Create "bus" and "class" dirs at init dlech/umockdev
1 participant
@dlech