Add some stub impl.

martinthomson · Sep 17, 2014 · a8a93cc · a8a93cc
1 parent 21a635a
commit a8a93cc
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 14 deletions.
diff --git a/media/webrtc/signaling/src/sdp/SipccSdp.cpp b/media/webrtc/signaling/src/sdp/SipccSdp.cpp
@@ -8,14 +8,36 @@
 
 namespace mozilla {
 
+SdpOrigin
+SipccSdp::GetOrigin() const {
+  return SdpOrigin();
+}
+
+std::string
+SipccSdp::GetSessionName() const {
+  return "TODO";
+}
+
+std::string
+SipccSdp::GetBandwidth(std::string type) const {
+  return "TODO";
+}
+
 const SdpMediaSection &
 SipccSdp::GetMediaSection(uint16_t level) const
 {
+  if (level >= mMediaSections.size()) {
+    MOZ_CRASH();
+  }
   return mMediaSections[level];
 }
+
 SdpMediaSection &
 SipccSdp::GetMediaSection(uint16_t level)
 {
+  if (level >= mMediaSections.size()) {
+    MOZ_CRASH();
+  }
   return mMediaSections[level];
 }
 

diff --git a/media/webrtc/signaling/src/sdp/SipccSdp.h b/media/webrtc/signaling/src/sdp/SipccSdp.h
@@ -30,26 +30,28 @@ class SipccSdp MOZ_FINAL : public Sdp
     sdp_free_description(mSdp);
   }
 
-  const SdpAttributeList& GetAttributeList() const {
-    return mAttributeList;
+  virtual SdpOrigin GetOrigin() const MOZ_OVERRIDE;
+  virtual std::string GetSessionName() const MOZ_OVERRIDE;
+  // Note: connection information is always retrieved from media sections
+  virtual std::string GetBandwidth(std::string type) const MOZ_OVERRIDE;
+
+  virtual uint16_t GetMediaSectionCount() const MOZ_OVERRIDE {
+    return static_cast<uint16_t>(mMediaSections.size());
   }
-  SdpAttributeList& GetAttributeList() {
+
+  virtual const SdpAttributeList &GetAttributeList() const MOZ_OVERRIDE {
     return mAttributeList;
   }
 
-  const SdpMediaSection &GetMediaSection(uint16_t level) const {
-    if (level >= mMediaSections.length()) {
-      MOZ_CRASH();
-    }
-    return mMediaSections[level];
-  }
-  SdpMediaSection &GetMediaSection(uint16_t level) {
-    if (level >= mMediaSections.length()) {
-      MOZ_CRASH();
-    }
-    return mMediaSections[level];
+  virtual SdpAttributeList &GetAttributeList() MOZ_OVERRIDE {
+    return mAttributeList;
   }
 
+  virtual const SdpMediaSection &GetMediaSection(
+      uint16_t level) const MOZ_OVERRIDE;
+
+  virtual SdpMediaSection &GetMediaSection(uint16_t level) MOZ_OVERRIDE;
+
 private:
   SipccSdp(sdp_t* sdp) : mSdp(sdp) {}