-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd: --branch
option for git fetch
.
#1146
Conversation
560f761
to
c9ab741
Compare
FYI, I have a synced-to-head version of this at https://github.com/ilyagr/jj/tree/fetch-glob. The test there is a union of the test from head and my test, and needs to be merged more intelligently. It's buggy enough that I couldn't put it here easily (I haven't tried doing
|
7c9efa6
to
7234fc4
Compare
There are a couple of known outstanding bugs (search for BUG in the tests). However, I think it's better to check this in as is rather than leave it hanging. I'll file these bugs as I submit this. |
--glob
option for git fetch
.--branch
option for git fetch
.
64c4325
to
fae335e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am all for including this soon, this is a feature I will use very often when pulling a pull request from a third-party repository without getting the whole content.
There is one thing I'm unsure about (the refspec) and I've let a comment on it, I would be more confident if you included the output of get_branch_output()
at several points in the test.
799b1c6
to
7deb556
Compare
d707573
to
525819f
Compare
Thanks to @samueltardieu for noticing a subtle bug in the refspecs, providing the fix, as well as the two `conflicting_branches` tests.
Thanks Samuel! |
The main contribution here are the detailed tests.
There is an outstanding bug with the way
undo
interacts withjj git fetch --branch
.Checklist
Todo:
CHANGELOG.md