Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: demonstrate bug on undo after squash in colocated working copy #1159

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

martinvonz
Copy link
Owner

I think this is the same bug as reported in #922, just simplified a bit further. The branches in the repo actually look good after the undo operation, but the reverted master branch doesn't get exported to the git repo even though our recorded refs/heads/master in the repo was moved back. Then the next automatic import on log notices that the master branch in the git repo still points to the new commit, and that commit becomes visible again.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have added tests to cover my changes

@martinvonz martinvonz enabled auto-merge (rebase) January 31, 2023 05:54
I think this is the same bug as reported in #922, just simplified a
bit further. The branches in the repo actually look good after the
`undo` operation, but the reverted `master` branch doesn't get
exported to the git repo even though our recorded `refs/heads/master`
in the repo was moved back. Then the next automatic import on `log`
notices that the `master` branch in the git repo still points to the
new commit, and that commit becomes visible again.
@martinvonz martinvonz merged commit 910c73a into main Jan 31, 2023
@martinvonz martinvonz deleted the push-f02813fd7071 branch January 31, 2023 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants