cargo: stop cargo install from installing fake-editor & co.
#2277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Among other things, this prevented `jj` from working with `cargo binstall`. The trick is taken from rust-lang/cargo#2911 (comment). We could now also remove `--bin jj` from the installation commands in `install-and-setup.md`, but I'm not sure we should. That argument makes it clear that the binary is `jj`, not `jj-cli`. Fixes martinvonz#216.
|
FYI, I renamed the feature to I'll wait until I have a moment to glance at the github release action before merging this. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Among other things, this prevented
jjfrom working withcargo binstall.The trick is taken from
rust-lang/cargo#2911 (comment).
We could now also remove
--bin jjfrom the installation commands ininstall-and-setup.md, but I'm not sure we should. That argument makes it clear that the binary isjj, notjj-cli.Fixes #216.
Checklist
If applicable:
CHANGELOG.md