Skip to content

Commit

Permalink
added BUILDING_NODE_EXTENSION define to binding.gyp (#25)
Browse files Browse the repository at this point in the history
* added BUILDING_NODE_EXTENSION define to binding.gyp, to allow for electron builds on windows

* set win_delay_load_hook true, to allow for electron builds on windows
  • Loading branch information
cdegalitt authored Nov 19, 2020
1 parent 79c98dd commit f0117fc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions binding.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
"include_dirs": ["vendor/libxml/include", "<!(node -e \"require('nan')\")"],
"cflags": ["-Wall"],
"xcode_settings": {"OTHER_CFLAGS": ["-Wall"]},
"win_delay_load_hook": "false",
"defines": ["LIBXML_XINCLUDE_ENABLED"],
"win_delay_load_hook": "true",
"defines": ["LIBXML_XINCLUDE_ENABLED", "BUILDING_NODE_EXTENSION"],
"sources": [
"src/libxmljs.cc",
"src/xml_attribute.cc",
Expand Down

0 comments on commit f0117fc

Please sign in to comment.