Add Document.schematronValidate method #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you split the test to check valid/invalid in seperate tests? Thanks though! Looks good. |
|
I wrote the test using 'validate' and 'rngValidate' as a reference. If you wish to split this test then other tests needs to be splitted too. |
|
You are correct. Lets leave it like this and I will split them someday in the future (the original is also not by me) |
marudor
pushed a commit
that referenced
this pull request
Dec 21, 2020
* + implement Document.schematronValidate() method * + add schematronValidate test * * fix indentation * * fix spacing * * fix linter errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libxml contains code to run schematron validation. I added it to libxmljs similar to rngValidate and validate methods we aready have there.