Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support gopkg.in packages #18

Merged
merged 1 commit into from
Mar 2, 2023
Merged

feat: support gopkg.in packages #18

merged 1 commit into from
Mar 2, 2023

Conversation

maxbrunet
Copy link
Contributor

@maxbrunet maxbrunet commented Dec 2, 2022 •
edited
Loading

Hello! 👋

The gopkg.in domain is a special case in the Go module specification:

As a special case, modules paths starting with gopkg.in/ must always have a major version suffix, even at v0 and v1. The suffix must start with a dot rather than a slash (for example, gopkg.in/yaml.v2).

References

@maxbrunet maxbrunet mentioned this pull request Dec 2, 2022
Merged
6 tasks
@maxbrunet
Copy link
Contributor Author

@marwan-at-work friendly nudge, would you have time to review this PR, please? 🙂

@maxbrunet maxbrunet mentioned this pull request Jan 4, 2023
Closed
marwan-at-work
marwan-at-work approved these changes Mar 2, 2023
View reviewed changes
Copy link
Owner

@marwan-at-work marwan-at-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution and sorry about the delay :)

@marwan-at-work marwan-at-work merged commit d88d15f into marwan-at-work:master Mar 2, 2023
@maxbrunet maxbrunet mentioned this pull request Mar 3, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marwan-at-work marwan-at-work marwan-at-work approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxbrunet @marwan-at-work