Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset time and stats when resetting an endpoint #34

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

dbechrd
Copy link
Contributor

@dbechrd dbechrd commented Aug 25, 2024

While resetting the stats isn't strictly necessary, it seems like a bit of a bug to me since the old values will be considered as part of the smoothing function.

Resetting time also isn't necessary with respect to reliable_endpoint_update, because the first thing it does is overwrites it, but it also gets used in reliable_endpoint_receive_packet to update rtt, so maybe it's a good idea to reset it, too? Whether it's the old value, or zero, it would be a bug in reliable_endpoint_receive_packet, so I'm just assuming that reliable_endpoint_update always gets called before reliable_endpoint_receive_packet after a reset. The zero feels like an easier bug to catch if someone calls them in the wrong order. 🤷

Signed-off-by: Dan Bechard <dbechrd@gmail.com>
@gafferongames gafferongames merged commit 208f5be into mas-bandwidth:main Aug 25, 2024
6 checks passed
@gafferongames
Copy link
Collaborator

Sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants