Reset time and stats when resetting an endpoint #34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While resetting the stats isn't strictly necessary, it seems like a bit of a bug to me since the old values will be considered as part of the smoothing function.
Resetting time also isn't necessary with respect to
reliable_endpoint_update
, because the first thing it does is overwrites it, but it also gets used inreliable_endpoint_receive_packet
to updatertt
, so maybe it's a good idea to reset it, too? Whether it's the old value, or zero, it would be a bug inreliable_endpoint_receive_packet
, so I'm just assuming thatreliable_endpoint_update
always gets called beforereliable_endpoint_receive_packet
after a reset. The zero feels like an easier bug to catch if someone calls them in the wrong order. 🤷