🧹 Prefer isEmpty to equality check

mas-cli · Apr 27, 2021 · 65b3763 · 65b3763
1 parent 2cf5ce3
commit 65b3763
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Sources/MasKit/Commands/SignIn.swift b/Sources/MasKit/Commands/SignIn.swift
@@ -31,7 +31,7 @@ public struct SignInCommand: CommandProtocol {
             printInfo("Signing in to Apple ID: \(options.username)")
 
             let password: String = {
-                if options.password == "", !options.dialog {
+                if options.password.isEmpty, !options.dialog {
                     return String(validatingUTF8: getpass("Password: "))!
                 }
                 return options.password

diff --git a/Sources/MasKit/Models/SoftwareProduct.swift b/Sources/MasKit/Models/SoftwareProduct.swift
@@ -30,7 +30,7 @@ extension SoftwareProduct {
 
     /// Returns bundleIdentifier if appName is empty string.
     var appNameOrBundleIdentifier: String {
-        appName == "" ? bundleIdentifier : appName
+        appName.isEmpty ? bundleIdentifier : appName
     }
 
     func isOutdatedWhenComparedTo(_ storeApp: SearchResult) -> Bool {