Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Distribution.plist; replace with a heredoc / process substitution in script/package #677

Closed
rgoldberg opened this issue Dec 11, 2024 · 4 comments
Assignees
Labels
🧽 chore Administrative task: documentation, build, test, release, git, etc.

Comments

@rgoldberg
Copy link
Contributor

rgoldberg commented Dec 11, 2024

Remove Distribution.plist; replace a with heredoc / process substitution in script/package.

@rgoldberg rgoldberg added 🧽 chore Administrative task: documentation, build, test, release, git, etc. 💬 team discussion labels Dec 11, 2024
@phatblat
Copy link
Member

The Distribution.plist file is the config for generating the macOS installer .pkg. Is there a newer way to build them?

@rgoldberg
Copy link
Contributor Author

rgoldberg commented Dec 14, 2024

@phatblat The idea was just to use process substitution (probably a file-based =(printf …), but a pipe-based<(printf …) if the latter will work, which it probably won't) to provide the content from Distribution.plist to the productbuild call in script/package, so the details are in the script & we don't have a file sitting in git that's only used in one place.

@phatblat
Copy link
Member

Ah, that's a good idea. It can just be a heredoc input in a script.

@rgoldberg rgoldberg changed the title Remove Distribution.plist; replace with process substitution in script/package Remove Distribution.plist; replace with a heredoc / process substitution in script/package Dec 15, 2024
@rgoldberg
Copy link
Contributor Author

Resolved by #640.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 chore Administrative task: documentation, build, test, release, git, etc.
Projects
None yet
Development

No branches or pull requests

2 participants