Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release improvements #640

Merged
merged 131 commits into from
Dec 23, 2024
Merged

Conversation

rgoldberg
Copy link
Contributor

@rgoldberg rgoldberg commented Nov 16, 2024

@phatblat

Note: I repeatedly rebase this PR's branch, so if you want to look at (or test) my release process, please force pull this PR's branch before so doing.

Moved release overhaul details to issue #638.

See corresponding custom tap PR at mas-cli/homebrew-tap#67.

Resolve #658
Resolve #656
Resolve #654
Resolve #638
Resolve #636
Resolve #635
Resolve #634
Resolve #628

@rgoldberg rgoldberg requested a review from phatblat November 16, 2024 12:52
@rgoldberg rgoldberg force-pushed the 638-release-improvements branch 6 times, most recently from 03de1d2 to 8306c6e Compare November 17, 2024 00:13
@rgoldberg rgoldberg force-pushed the 638-release-improvements branch 7 times, most recently from 0faa0f8 to ef6bd6e Compare November 18, 2024 06:56
@rgoldberg
Copy link
Contributor Author

@phatblat I've incorporated your fixes from the 638/release-fixes branch in this repo into my branch for this PR, so you can restart using the branch from this PR.

If you have any other fixes that weren't already in that branch in this repo at the time when this comment was posted, please share them with me so I can incorporate them into the branch for this PR.

Thanks.

@rgoldberg rgoldberg force-pushed the 638-release-improvements branch 4 times, most recently from f06fedd to 4856cee Compare November 20, 2024 06:07
@rgoldberg rgoldberg mentioned this pull request Nov 20, 2024
@rgoldberg rgoldberg added this to the 1.8.8 milestone Nov 21, 2024
@rgoldberg rgoldberg force-pushed the 638-release-improvements branch 3 times, most recently from 41c1f62 to aabdb51 Compare November 21, 2024 20:45
@rgoldberg rgoldberg self-assigned this Nov 21, 2024
@rgoldberg rgoldberg added the 🧽 chore Administrative task: documentation, build, test, release, git, etc. label Nov 21, 2024
@rgoldberg rgoldberg force-pushed the 638-release-improvements branch from 94bf065 to 02f2bd4 Compare November 23, 2024 11:55
Partial mas-cli#638

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
…Bump mas-cli/tap/mas formula` step.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
…in `tag-pushed.yml`.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
…d.yml`.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
…li/tap/mas formula` step in `tag-pushed` job in `tag-pushed.yml`.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Avoid warning from checkout step.

Partial mas-cli#638

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg rgoldberg force-pushed the 638-release-improvements branch from 641a2e9 to 567a330 Compare December 20, 2024 18:27
Partial mas-cli#638

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Partial mas-cli#638

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Partial mas-cli#638

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Partial mas-cli#638

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Partial mas-cli#638

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg rgoldberg marked this pull request as ready for review December 22, 2024 17:58
@rgoldberg rgoldberg requested a review from a team as a code owner December 22, 2024 17:58
@rgoldberg rgoldberg requested a review from phatblat December 22, 2024 17:58
Partial mas-cli#638

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg rgoldberg force-pushed the 638-release-improvements branch from 53533c3 to a3a00fc Compare December 22, 2024 21:12
phatblat
phatblat previously approved these changes Dec 22, 2024
Copy link
Member

@phatblat phatblat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work cleaning all this up and great job reworking the release process! 🎉

Partial mas-cli#638

Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
@rgoldberg rgoldberg merged commit c8dc938 into mas-cli:main Dec 23, 2024
3 checks passed
@rgoldberg rgoldberg deleted the 638-release-improvements branch December 23, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment