Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version to search #131

Merged
merged 3 commits into from
Feb 13, 2018
Merged

add version to search #131

merged 3 commits into from
Feb 13, 2018

Conversation

brianbrownton
Copy link
Contributor

@brianbrownton brianbrownton commented Feb 8, 2018

not much more to say!

old:

$ mas search quip
1003160018 Quip
1002623276 Quiplash

new hotness:

$ ./mas search quip
1003160018 Quip 5.2.18
1002623276 Quiplash 1.0.0

@brianbrownton brianbrownton mentioned this pull request Feb 8, 2018
@phatblat
Copy link
Member

Resolves #130

@phatblat phatblat self-requested a review February 11, 2018 02:16
@phatblat phatblat added this to the 1.4 milestone Feb 11, 2018
Copy link
Member

@phatblat phatblat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but can you add parentheses?

let appId = result[ResultKeys.TrackId] as? Int {
print("\(String(appId)) \(appName)")
print("\(String(appId)) \(appName) \(appVersion)")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add parentheses around the version? That will match the output of the outdated better and give a pattern for scripts to locate the version number easier.

@brianbrownton
Copy link
Contributor Author

Parenthesis added.

$ mas search quip
1003160018 Quip (5.2.26)
1002623276 Quiplash (1.0.0)

@phatblat phatblat merged commit 5011393 into mas-cli:master Feb 13, 2018
@phatblat phatblat mentioned this pull request Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants