Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔀 Merge 1.7.1 hotfix into master #302

Closed
wants to merge 31 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
9008ea3
🛠 Apply Xcode 12b6 recommended settings
phatblat Sep 3, 2020
902ad4e
🤡 Add/update search JSON examples
phatblat Sep 3, 2020
8c70832
🧹 Include Carthage/Build in clean script
phatblat Sep 6, 2020
46f2a76
🔧 Disable force_try swiftlint rule for tests
phatblat Sep 6, 2020
eb4403b
⬆️ Quick (3.0.0), Nimble (8.1.1)
phatblat Sep 6, 2020
838cc63
🔥 Remove obsolete project reference to Result framework
phatblat Sep 6, 2020
6f3f9be
♻️ Revise API for local JSON fixtures
phatblat Sep 6, 2020
27839a5
✅ Add SearchResultListSpec
phatblat Sep 6, 2020
849cbef
🎨 Format source
phatblat Sep 6, 2020
48cf390
🐛 Account for missing JSON fields in search results
phatblat Sep 6, 2020
7699470
📝 Update changelog
phatblat Sep 7, 2020
f7057e2
📦 Update brew lockfile
phatblat Sep 7, 2020
a9eda10
🎨 Format source
phatblat Sep 7, 2020
de0ad8d
⬆️ Quick (3.0.0), Nimble (8.1.2)
phatblat Sep 7, 2020
d217938
👽 Remove force try from tests
phatblat Sep 7, 2020
4ad7b8d
Merge pull request #299 from mas-cli/search-json
phatblat Sep 7, 2020
8b4f882
📝 Update changelog
phatblat Sep 7, 2020
15af8ec
🙈 Ignore default.profraw
phatblat Sep 7, 2020
4ad481c
🔖 Version 1.7.1
phatblat Sep 7, 2020
9d9ef26
🍺 Update formula for 1.7.0
phatblat Sep 7, 2020
b8dcb4c
Merge pull request #300 from mas-cli/release-1.7.1
phatblat Sep 7, 2020
800a2f9
🍺 Update formula tag and revision
phatblat Sep 7, 2020
51a4af5
📜 Add build_artifacts script
phatblat Sep 7, 2020
6576d41
🍺 Update formula with differences from homebrew-core
phatblat Sep 7, 2020
8e09573
🐛 Fix dynamic REVISION in formula script
phatblat Sep 7, 2020
73991b0
🐛 Stability fixes for bottle script
phatblat Sep 7, 2020
47b2867
🔧 Revise editorconfig globs
phatblat Sep 7, 2020
b39dc90
📜 Add brew_update script
phatblat Sep 7, 2020
8a24712
🍼 Update custom tap bottle hashes
phatblat Sep 7, 2020
461322b
🍼 Update bottle hashes after BrewTestBot build
phatblat Sep 7, 2020
635fe52
Merge pull request #301 from mas-cli/formula-1.7.1
phatblat Sep 7, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@ insert_final_newline = true
[*.md]
trim_trailing_whitespace = false

[{script/*,*.rb,*.yml}]
[{script/*,*.{rb,yml}}]
indent_size = 2
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,6 @@ Pods/
Temporary Items
bin/
build/
default.profraw
releases/
xcuserdata
10 changes: 5 additions & 5 deletions Brewfile.lock.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,12 @@
"system": {
"macos": {
"catalina": {
"HOMEBREW_VERSION": "2.2.17-96-g2e801c3",
"HOMEBREW_VERSION": "2.4.16-180-gb2d9594",
"HOMEBREW_PREFIX": "/usr/local",
"Homebrew/homebrew-core": "572fc56b93562aa2d07749e826f8b4ab6cc04090",
"CLT": "11.0.0.0.1.1567737322",
"Xcode": "11.5",
"macOS": "10.15.4"
"Homebrew/homebrew-core": "85bdb1a3845135bb3b7311ae6adcae8c82447951",
"CLT": "1103.0.32.62",
"Xcode": "11.6",
"macOS": "10.15.6"
}
}
}
Expand Down
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

## [v1.7.1] 🐛 Search JSON Fix - 2020-09-06

- 🐛 Account for missing JSON fields in search results #299

## [v1.7.0] 🛍 Purchase Command - 2020-05-24

- ✨ New `purchase` command for purchasing free apps #264 (resolves #2, #145)
Expand Down Expand Up @@ -200,7 +204,8 @@ Use the `mas.pkg` package to install manually.

- Initial Release

[Unreleased]: https://github.com/mas-cli/mas/compare/v1.7.0...HEAD
[Unreleased]: https://github.com/mas-cli/mas/compare/v1.7.1...HEAD
[v1.7.1]: https://github.com/mas-cli/mas/compare/v1.7.0...v1.7.1
[v1.7.0]: https://github.com/mas-cli/mas/compare/v1.6.4...v1.7.0
[v1.6.4]: https://github.com/mas-cli/mas/compare/v1.6.3...v1.6.4
[v1.6.3]: https://github.com/mas-cli/mas/compare/v1.6.2...v1.6.3
Expand Down
4 changes: 2 additions & 2 deletions Cartfile.resolved
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
github "Carthage/Commandant" "0.17.0"
github "Quick/Nimble" "v8.0.9"
github "Quick/Quick" "v2.2.0"
github "Quick/Nimble" "v8.1.2"
github "Quick/Quick" "v3.0.0"
36 changes: 24 additions & 12 deletions Carthage/Checkouts/Nimble/.github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,29 +6,41 @@ on:
- master
pull_request:
branches:
- '*'
- "*"

jobs:
cocoapods:
name: CocoaPods Lint
runs-on: macos-latest
steps:
- uses: actions/checkout@v2
- run: bundle install
- run: ./test podspec

xcode:
name: Xcode ${{ matrix.xcode }}
runs-on: macOS-latest
runs-on: macos-latest
strategy:
matrix:
xcode: [11, 11.1, 11.2]
xcode: [10.3, 11, 11.1, 11.2]
fail-fast: false
env:
DEVELOPER_DIR: /Applications/Xcode_${{ matrix.xcode }}.app
steps:
- uses: actions/checkout@v2
- run: sudo xcode-select -s '/Applications/Xcode_${{ matrix.xcode }}.app'
- run: ./test macos
- run: ./test ios
- run: ./test tvos
- uses: actions/checkout@v2
- run: ./test macos
- run: ./test ios
- run: ./test tvos

swiftpm_darwin:
name: SwiftPM, Darwin, Xcode ${{ matrix.xcode }}
runs-on: macOS-latest
runs-on: macos-latest
strategy:
matrix:
xcode: [11, 11.1, 11.2]
fail-fast: false
env:
DEVELOPER_DIR: /Applications/Xcode_${{ matrix.xcode }}.app
steps:
- uses: actions/checkout@v2
- run: sudo xcode-select -s '/Applications/Xcode_${{ matrix.xcode }}.app'
- run: ./test swiftpm
- uses: actions/checkout@v2
- run: ./test swiftpm
19 changes: 7 additions & 12 deletions Carthage/Checkouts/Nimble/.travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,6 @@ branches:
language: generic
jobs:
include:
- &cocoapods
name: CocoaPods Lint
os: osx
osx_image: xcode10.3
install: bundle install
script: ./test podspec
- &xcode
name: Xcode 10.1 / Swift 4.2
os: osx
Expand All @@ -20,9 +14,6 @@ jobs:
- ./test macos
- ./test ios
- ./test tvos
- <<: *xcode
name: Xcode 10.3 / Swift 5.0
osx_image: xcode10.3
- &swiftpm_darwin
name: SwiftPM / Darwin / Swift 4.2
os: osx
Expand All @@ -49,13 +40,17 @@ jobs:
env:
- SWIFT_VERSION=5.1.5
- <<: *swiftpm_linux
name: SwiftPM / Linux / Swift 5.2.2
name: SwiftPM / Linux / Swift 5.2.4
env:
- SWIFT_VERSION=5.2.4
- <<: *swiftpm_linux
name: SwiftPM / Linux / Swift 5.3 Development
env:
- SWIFT_VERSION=5.2.2
- SWIFT_VERSION=5.3-DEVELOPMENT-SNAPSHOT-2020-05-19-a
- <<: *swiftpm_linux
name: SwiftPM / Linux / Swift Development
env:
- SWIFT_VERSION=DEVELOPMENT-SNAPSHOT-2020-04-17-a
- SWIFT_VERSION=DEVELOPMENT-SNAPSHOT-2020-05-26-a
install: true
script:
- ./test $TYPE
Expand Down
50 changes: 32 additions & 18 deletions Carthage/Checkouts/Nimble/Gemfile.lock
Original file line number Diff line number Diff line change
@@ -1,65 +1,79 @@
GEM
remote: https://rubygems.org/
specs:
CFPropertyList (3.0.0)
activesupport (4.2.11.1)
CFPropertyList (3.0.2)
activesupport (4.2.11.3)
i18n (~> 0.7)
minitest (~> 5.1)
thread_safe (~> 0.3, >= 0.3.4)
tzinfo (~> 1.1)
algoliasearch (1.27.3)
httpclient (~> 2.8, >= 2.8.3)
json (>= 1.5.1)
atomos (0.1.3)
claide (1.0.2)
cocoapods (1.7.1)
claide (1.0.3)
cocoapods (1.9.3)
activesupport (>= 4.0.2, < 5)
claide (>= 1.0.2, < 2.0)
cocoapods-core (= 1.7.1)
cocoapods-core (= 1.9.3)
cocoapods-deintegrate (>= 1.0.3, < 2.0)
cocoapods-downloader (>= 1.2.2, < 2.0)
cocoapods-plugins (>= 1.0.0, < 2.0)
cocoapods-search (>= 1.0.0, < 2.0)
cocoapods-stats (>= 1.0.0, < 2.0)
cocoapods-trunk (>= 1.3.1, < 2.0)
cocoapods-trunk (>= 1.4.0, < 2.0)
cocoapods-try (>= 1.1.0, < 2.0)
colored2 (~> 3.1)
escape (~> 0.0.4)
fourflusher (>= 2.2.0, < 3.0)
fourflusher (>= 2.3.0, < 3.0)
gh_inspector (~> 1.0)
molinillo (~> 0.6.6)
nap (~> 1.0)
ruby-macho (~> 1.4)
xcodeproj (>= 1.8.2, < 2.0)
cocoapods-core (1.7.1)
xcodeproj (>= 1.14.0, < 2.0)
cocoapods-core (1.9.3)
activesupport (>= 4.0.2, < 6)
algoliasearch (~> 1.0)
concurrent-ruby (~> 1.1)
fuzzy_match (~> 2.0.4)
nap (~> 1.0)
netrc (~> 0.11)
typhoeus (~> 1.0)
cocoapods-deintegrate (1.0.4)
cocoapods-downloader (1.2.2)
cocoapods-downloader (1.3.0)
cocoapods-plugins (1.0.0)
nap
cocoapods-search (1.0.0)
cocoapods-stats (1.1.0)
cocoapods-trunk (1.3.1)
cocoapods-trunk (1.5.0)
nap (>= 0.8, < 2.0)
netrc (~> 0.11)
cocoapods-try (1.1.0)
cocoapods-try (1.2.0)
colored2 (3.1.2)
concurrent-ruby (1.1.5)
concurrent-ruby (1.1.6)
escape (0.0.4)
fourflusher (2.3.0)
ethon (0.12.0)
ffi (>= 1.3.0)
ffi (1.13.0)
fourflusher (2.3.1)
fuzzy_match (2.0.4)
gh_inspector (1.1.3)
httpclient (2.8.3)
i18n (0.9.5)
concurrent-ruby (~> 1.0)
minitest (5.11.3)
json (2.3.0)
minitest (5.14.1)
molinillo (0.6.6)
nanaimo (0.2.6)
nap (1.1.0)
netrc (0.11.0)
ruby-macho (1.4.0)
thread_safe (0.3.6)
tzinfo (1.2.5)
typhoeus (1.4.0)
ethon (>= 0.9.0)
tzinfo (1.2.7)
thread_safe (~> 0.1)
xcodeproj (1.9.0)
xcodeproj (1.16.0)
CFPropertyList (>= 2.3.3, < 4.0)
atomos (~> 0.1.3)
claide (>= 1.0.2, < 2.0)
Expand All @@ -73,4 +87,4 @@ DEPENDENCIES
cocoapods (~> 1.7)

BUNDLED WITH
1.17.3
2.1.4
2 changes: 1 addition & 1 deletion Carthage/Checkouts/Nimble/Nimble.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |s|
s.name = "Nimble"
s.version = "8.0.9"
s.version = "8.1.2"
s.summary = "A Matcher Framework for Swift and Objective-C"
s.description = <<-DESC
Use Nimble to express the expected outcomes of Swift or Objective-C expressions. Inspired by Cedar.
Expand Down
2 changes: 1 addition & 1 deletion Carthage/Checkouts/Nimble/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -1186,7 +1186,7 @@ expect {
let notificationCenter = NotificationCenter()
expect {
notificationCenter.postNotification(testNotification)
}.to(postNotifications(equal([testNotification]), fromNotificationCenter: notificationCenter))
}.to(postNotifications(equal([testNotification]), from: notificationCenter))
```

> This matcher is only available in Swift.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ private let mainThread = pthread_self()

public func postNotifications(
_ predicate: Predicate<[Notification]>,
fromNotificationCenter center: NotificationCenter = .default
from center: NotificationCenter = .default
) -> Predicate<Any> {
_ = mainThread // Force lazy-loading of this value
let collector = NotificationCollector(notificationCenter: center)
Expand Down Expand Up @@ -66,12 +66,18 @@ public func postNotifications(
}
}

@available(*, deprecated, renamed: "postNotifications(_:from:)")
public func postNotifications(
_ predicate: Predicate<[Notification]>,
fromNotificationCenter center: NotificationCenter
) -> Predicate<Any> {
return postNotifications(predicate, from: center)
}

public func postNotifications<T>(
_ notificationsMatcher: T,
fromNotificationCenter center: NotificationCenter = .default)
-> Predicate<Any>
where T: Matcher, T.ValueType == [Notification]
{
from center: NotificationCenter = .default
)-> Predicate<Any> where T: Matcher, T.ValueType == [Notification] {
_ = mainThread // Force lazy-loading of this value
let collector = NotificationCollector(notificationCenter: center)
collector.startObserving()
Expand All @@ -98,3 +104,11 @@ public func postNotifications<T>(
return PredicateResult(bool: match, message: failureMessage.toExpectationMessage())
}
}

@available(*, deprecated, renamed: "postNotifications(_:from:)")
public func postNotifications<T>(
_ notificationsMatcher: T,
fromNotificationCenter center: NotificationCenter
)-> Predicate<Any> where T: Matcher, T.ValueType == [Notification] {
return postNotifications(notificationsMatcher, from: center)
}
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,12 @@
#import <Nimble/Nimble-Swift.h>
#endif

__attribute__((constructor))
static void registerCurrentTestCaseTracker(void) {
#pragma mark - Private

@implementation XCTestObservationCenter (Register)

+ (void)load {
[[XCTestObservationCenter sharedTestObservationCenter] addTestObserver:[CurrentTestCaseTracker sharedInstance]];
}

@end
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,14 @@ final class PostNotificationTest: XCTestCase, XCTestCaseProvider {
expect {
// no notifications here!
return nil
}.to(postNotifications(beEmpty(), fromNotificationCenter: notificationCenter))
}.to(postNotifications(beEmpty()))
}

func testPassesWhenExpectedNotificationIsPosted() {
let testNotification = Notification(name: Notification.Name("Foo"), object: nil)
expect {
self.notificationCenter.post(testNotification)
}.to(postNotifications(equal([testNotification]), fromNotificationCenter: notificationCenter))
}.to(postNotifications(equal([testNotification]), from: notificationCenter))
}

func testPassesWhenAllExpectedNotificationsArePosted() {
Expand All @@ -28,7 +28,7 @@ final class PostNotificationTest: XCTestCase, XCTestCaseProvider {
self.notificationCenter.post(n1)
self.notificationCenter.post(n2)
return nil
}.to(postNotifications(equal([n1, n2]), fromNotificationCenter: notificationCenter))
}.to(postNotifications(equal([n1, n2]), from: notificationCenter))
}

func testFailsWhenNoNotificationsArePosted() {
Expand All @@ -37,7 +37,7 @@ final class PostNotificationTest: XCTestCase, XCTestCaseProvider {
expect {
// no notifications here!
return nil
}.to(postNotifications(equal([testNotification]), fromNotificationCenter: self.notificationCenter))
}.to(postNotifications(equal([testNotification]), from: self.notificationCenter))
}
}

Expand All @@ -48,7 +48,7 @@ final class PostNotificationTest: XCTestCase, XCTestCaseProvider {
expect {
self.notificationCenter.post(n2)
return nil
}.to(postNotifications(equal([n1]), fromNotificationCenter: self.notificationCenter))
}.to(postNotifications(equal([n1]), from: self.notificationCenter))
}
}

Expand All @@ -59,7 +59,7 @@ final class PostNotificationTest: XCTestCase, XCTestCaseProvider {
expect {
self.notificationCenter.post(n2)
return nil
}.to(postNotifications(equal([n1]), fromNotificationCenter: self.notificationCenter))
}.to(postNotifications(equal([n1]), from: self.notificationCenter))
}
}

Expand All @@ -70,6 +70,6 @@ final class PostNotificationTest: XCTestCase, XCTestCaseProvider {
self.notificationCenter.post(testNotification)
}
return nil
}.toEventually(postNotifications(equal([testNotification]), fromNotificationCenter: notificationCenter))
}.toEventually(postNotifications(equal([testNotification]), from: notificationCenter))
}
}
Loading