Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple Silicon Github-hosted runner for build-test job #508

Merged
merged 4 commits into from
Feb 17, 2024

Conversation

rgoldberg
Copy link
Contributor

@rgoldberg rgoldberg commented Feb 4, 2024

Apple Silicon Github-hosted runner for build-test job.

See #496 (comment)

@rgoldberg rgoldberg requested a review from a team as a code owner February 4, 2024 15:47
@GreyTeardrop
Copy link

Looks like swift-format is failing on the macos-14 runner. Their README says the latest version could be used for all Swift 5.8+ platforms.

@rgoldberg
Copy link
Contributor Author

@GreyTeardrop Thanks. I pushed an update. I need to fix some formatting issues in existing files. Will do so later.

@rgoldberg rgoldberg marked this pull request as draft February 5, 2024 07:58
swiftformat Sources Tests
@rgoldberg rgoldberg marked this pull request as ready for review February 5, 2024 21:07
@rgoldberg
Copy link
Contributor Author

rgoldberg commented Feb 5, 2024

@GreyTeardrop Passing all checks now. Can you pull my changes, then create a new PR that is exactly the same as this one? I can then approve it (I can't approve my own PR, and all the other organization members are MIA). Once approved, it will merge, then I can run the checks for #496, then approve that, then look into how to release a new version.

@GreyTeardrop
Copy link

@rgoldberg Will do now

@GreyTeardrop
Copy link

Opened #509

@phatblat phatblat merged commit ec503a1 into mas-cli:main Feb 17, 2024
5 checks passed
@rgoldberg rgoldberg deleted the apple-silicon-github-hosted-runner branch February 18, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants