Improve Account, SignIn, SignOut & ISStoreAccount extension & associated code:
#563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… associated code. Prevent `ISAccountService.signIn(with:)` deprecation warning. Improve macOS version handling encapsulation. Output error if `StoreAccount.signin(…)` provides a `nil` `ISStoreAccount`. Improve `signin` `"Already Signed In" error output. Remove unnecessary output. Simplify code. Partial mas-cli#562 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
…`StoreAccount`. Add `var dsID` to `StoreAccount` so functions can use `StoreAccount` without casting to `ISStoreAccount`. Simplify code. Partial mas-cli#562 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Move towards better purchase encapsulation: all purchase logic will eventually be in the `perform(…)` function, not in convenience constructor, to ensure the correct values are used when `perform(…)` is called, instead of values that were correct sometime before the call. Partial mas-cli#562 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Output error for non-`nil` `ISStoreAccount.primaryAccount` only if `ISStoreAccount.primaryAccount.isSignedIn` is `true`. Output error when no password provided to password prompt for `mas signin`. Remove unnecessary blank lines in `MASError.swift`. Partial mas-cli#562 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Partial mas-cli#562 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
Partial mas-cli#562 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
…init`. Partial mas-cli#562 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
…Purchase.perform(adamId:purchase:)` to encapsulate `CKPurchaseController` & its callback. Chain `Promise`s instead of calling `Promise.wait()`. Improve comments. Resolve mas-cli#562 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
rgoldberg
added
🧽 chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve
Account,SignIn,SignOut&ISStoreAccountextension & associated code:ISStoreAccountfrom Grand Central Dispatch to PromiseKit & improve PromiseKit usageISAccountService.signIn(with:)deprecation warningResolve #562