🐛 fix(InfiniteScroll): crashes when the parent element doesn't exist (#…

…2060)
masastack · Jul 23, 2024 · 3ab4af9 · 3ab4af9
1 parent c4ba565
commit 3ab4af9
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 3 deletions.
diff --git a/src/Masa.Blazor.JS/src/interop.ts b/src/Masa.Blazor.JS/src/interop.ts
@@ -1304,6 +1304,11 @@ export function checkIfThresholdIsExceededWhenScrolling(el: Element, parent: any
     parentElement = document.querySelector(parent);
   }
 
+  if (!parentElement) {
+    console.warn('[MInfiniteScroll] failed to get parent element with selector:', parent);
+    return;
+  }
+
   const rect = el.getBoundingClientRect();
   const elementTop = rect.top;
   const current = isWindow(parentElement)

diff --git a/src/Masa.Blazor/JSInterop/JsInteropConstants.cs b/src/Masa.Blazor/JSInterop/JsInteropConstants.cs
@@ -124,7 +124,7 @@ public static class JsInteropConstants
 
     public static string GetElementTranslateY => $"{JsInteropFuncNamePrefix}getElementTranslateY";
 
-    public static string CheckIfThresholdIsExceededWhenScrolling => $"{JsInteropFuncNamePrefix}checkIfThresholdIsExceededWhenScrolling";
+    internal static string CheckIfThresholdIsExceededWhenScrolling => $"{JsInteropFuncNamePrefix}checkIfThresholdIsExceededWhenScrolling";
 
     public static string SetProperty => $"{JsInteropFuncNamePrefix}setProperty";
 

diff --git a/src/Masa.Blazor/wwwroot/js/masa-blazor.js b/src/Masa.Blazor/wwwroot/js/masa-blazor.js
diff --git a/src/Masa.Blazor/wwwroot/js/masa-blazor.js.map b/src/Masa.Blazor/wwwroot/js/masa-blazor.js.map