🐛 fix(Sortable): the handle parameter shoulbe override with value null (

#2152)
masastack · Sep 14, 2024 · 92be124 · 92be124
1 parent 5286a6d
commit 92be124
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/src/Masa.Blazor.Docs.ApiGenerator/ApiGenerator.cs b/src/Masa.Blazor.Docs.ApiGenerator/ApiGenerator.cs
@@ -221,14 +221,30 @@ private static void AnalyzeParameters(INamedTypeSymbol classSymbol, List<Paramet
 
                         if (namedTypeSymbol.Name.StartsWith("RenderFragment"))
                         {
+                            // same name parameter from base class has been overridden, so ignore it.
+                            if (contentParameters.Any(u => u.Name == parameterInfo.Name))
+                            {
+                                continue;
+                            }
+
                             contentParameters.Add(parameterInfo);
                         }
                         else if (namedTypeSymbol.Name.StartsWith("EventCallback"))
                         {
+                            if (eventParameters.Any(u => u.Name == parameterInfo.Name))
+                            {
+                                continue;
+                            }
+
                             eventParameters.Add(parameterInfo);
                         }
                         else
                         {
+                            if (defaultParameters.Any(u => u.Name == parameterInfo.Name))
+                            {
+                                continue;
+                            }
+
                             defaultParameters.Add(parameterInfo);
                         }
                     }

diff --git a/src/Masa.Blazor/Components/Sortable/MSortable.razor.cs b/src/Masa.Blazor/Components/Sortable/MSortable.razor.cs
@@ -8,6 +8,8 @@ public partial class MSortable<TItem> : MSortableProviderBase<TItem>
 
     [Parameter] [MasaApiParameter("div")] public string? ItemTag { get; set; } = "div";
 
+    [Parameter] public override string? Handle { get; set; }
+
     private static Block _block = new("m-sortable");
     private ModifierBuilder _modifierBuilder = _block.CreateModifierBuilder();
 

diff --git a/src/Masa.Blazor/Components/Sortable/MSortableProviderBase.cs b/src/Masa.Blazor/Components/Sortable/MSortableProviderBase.cs
@@ -119,7 +119,7 @@ public bool Disabled
     /// </summary>
     [Parameter]
     [MasaApiParameter(".handle")]
-    public string? Handle { get; set; } = ".handle";
+    public virtual string? Handle { get; set; } = ".handle";
 
     /// <summary>
     /// Will always use inverted swap zone if set to true