feat; 멤버 가입(등록) API 작성하기 #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaeoni
commented
Jun 29, 2024
Comment on lines
+11
to
+21
| interface MemberUseCase { | ||
| data class CreateCommand( | ||
| val fullName: String, | ||
| val profileImageId: ImageId?, | ||
| val platform: MemberPlatform, | ||
| val ordinal: Int, | ||
| val gender: MemberGender, | ||
| ) | ||
|
|
||
| fun create(command: CreateCommand): MemberId | ||
| } |
There was a problem hiding this comment.
유즈케이스랑 서비스랑 메소드랑 코맨드 모델이 아예 똑같아서,, 유즈케이스라는 레이어가 하나 더 있는게 불필요하게 느껴지더라구요?
그래서 바로 컨트롤러에서 서비스 호출해도 되도록하면 어떨지 여러분들 의견도 궁금합니당
There was a problem hiding this comment.
아까 저도 이것과 관련하여 얘기를 해봤는데, API와 통신하는 것 UseCase만을 사용하도록 했던 것 같아요~~
yaeoni
force-pushed
the
yaeoni/member-create
branch
from
3dd2002 to
5bf42ea
Compare
xonmin
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[add] pr template작업 내용
비고 (첨부자료)