feat: 마이스페이스 내가 받은 픽 API #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toychip
force-pushed
the
junhyoung/add-myspace-mypick
branch
from
18ff5a4 to
9b81c2d
Compare
yaeoni
approved these changes
Aug 15, 2024
Comment on lines
+217
to
+220
| .orderBy( | ||
| Wildcard.count.desc(), | ||
| pickEntity.createdAt.desc() | ||
| ) |
There was a problem hiding this comment.
Wildcard.count 는 첨보는 형태네요 신기하네용
Comment on lines
139
to
168
| override fun receivedMySpacePicks(): List<PickService.MySpacePickDetail> { | ||
| // ToDo 실제 로그인 값으로 사용 | ||
| val currentMemberId = MemberId("currentMemberId") | ||
| val mySpacePicks = pickService.getReceivedMySpacePicks(currentMemberId) |
There was a problem hiding this comment.
이제 실제 로그인 값(멤버 아이디) 불러올 수 있어서 Todo 로 안박아도 될것 같아요!
xonmin
approved these changes
Aug 15, 2024
| @@ -7,4 +7,5 @@ spring: | |||
| dojo: | |||
| candidate: | |||
| size: 8 | |||
|
|
|||
| rank: | |||
toychip
force-pushed
the
junhyoung/add-myspace-mypick
branch
from
c4151b3 to
282973c
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[add] pr template작업 내용
비고 (첨부자료)
이번 리뷰도 잘 부탁드립니다.☺️