Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: entity skeleton structure #9

Closed
wants to merge 37 commits into from
Closed

feat: entity skeleton structure #9

wants to merge 37 commits into from

Conversation

toychip
Copy link
Member

@toychip toychip commented Jun 19, 2024 •
edited
Loading

  • πŸ”€ PR 제λͺ©μ˜ ν˜•μ‹μ„ 잘 μž‘μ„±ν–ˆλ‚˜μš”? e.g. [add] pr template
  • πŸ’― ν…ŒμŠ€νŠΈλŠ” 잘 ν†΅κ³Όν–ˆλ‚˜μš”?
  • πŸ—οΈ λΉŒλ“œλŠ” μ„±κ³΅ν–ˆλ‚˜μš”?
  • 🧹 λΆˆν•„μš”ν•œ μ½”λ“œλŠ” μ œκ±°ν–ˆλ‚˜μš”?

μž‘μ—… λ‚΄μš©

  • Entity λΌˆλŒ€λ₯Ό κ΅¬μΆ•ν–ˆμŠ΅λ‹ˆλ‹€.
스크란샷 2024-06-20 03 22 10
  • application-entity.yml νŒŒμΌμ„ application-entity-prod.yml, application-entity-local.yml둜 λΆ„λ¦¬ν–ˆμŠ΅λ‹ˆλ‹€.
    • ν™˜κ²½λ³€μˆ˜λ₯Ό Run > edit configuration > μ’Œμƒλ‹¨ Spring Bootμ—μ„œ μƒμ„±ν•˜μ—¬ ν™˜κ²½λ³€μˆ˜λ₯Ό κ΅¬μ„±ν•΄λ΄€μŠ΅λ‹ˆλ‹€.
    • λ©€ν‹°λͺ¨λ“ˆμ˜ ν™˜κ²½λ³€μˆ˜ ꡬ성은 처음이라.. 많이 λΆ€μ‘±ν•©λ‹ˆλ‹€. λ‹€λ₯Έ λ°©λ²•μ΄λ‚˜ μ‘°μ–Έν•΄μ£Όμ‹œλ©΄ λ„ˆλ¬΄λ‚˜ κ°μ‚¬ν•˜κ² μŠ΅λ‹ˆλ‹€ 😭
스크란샷 2024-06-20 03 25 31
  • Kotlin 포맷을 μ μš©ν•˜λ©΄ ν”„λ‘œνΌν‹°λ“€μ΄ λΆ™μ–΄μžˆκ²Œλ˜μ–΄ 가독성이 μ•ˆμ’‹κ³ , 가독성 μ’‹κ²Œν•˜μžλ‹ˆ buildκ°€ μ‹€νŒ¨ν•΄μ„œ μš°μ„  buildκ°€ μ„±κ³΅ν•˜λ„λ‘ μ˜¬λ €λ΄€μŠ΅λ‹ˆλ‹€.
  • 가독성이 쑰금 떨어지더라도 였λ₯Έμͺ½κ³Ό 같이 ν•˜λ©΄ λ˜λŠ”κ±ΈκΉŒμš”?
스크란샷 2024-06-20 11 29 19
  • Kotlin으둜 ν”„λ‘œμ νŠΈ 첫 μ½”λ“œ ꡬ성이라 많이 λΆ€μ‘±ν•©λ‹ˆλ‹€. κ°œμ„ ν•  λΆ€λΆ„ λ§μ”€ν•΄μ£Όμ‹œλ©΄ 이것 λ˜ν•œ λ„ˆλ¬΄ πŸ™Œκ°μ‚¬ν•˜κ² μŠ΅λ‹ˆλ‹€ πŸ™Œ

μŠ€ν¬λ¦°μƒ·

1μ°¨ ERD Diagram

스크란샷 2024-06-20 04 04 10

μ£Όμ˜μ‚¬ν•­

@toychip toychip requested review from xonmin, yaeoni and wonlog-g June 19, 2024 18:33
@xonmin
Copy link
Member

xonmin commented Jun 21, 2024

λ©€ν‹°λͺ¨λ“ˆ μ‹€ν–‰μ‹œ, Application 이 λ“€μ–΄κ°€μžˆλŠ”λ° api λͺ¨λ“ˆμ˜ resource - application.yml μ—μ„œ λ‹€λ₯Έ λͺ¨λ“ˆμ˜ application.yml 을 ν¬ν•¨ν•˜λ„λ‘ ν•  수 μžˆμŠ΅λ‹ˆλ‹€.
e.g )

spring: 
  profiles:
    active: dev
    include: core # μš”λΆ€λΆ„μ΄ λ‹€λ₯Έ 곳에 μ •μ˜λ˜μ–΄μžˆλŠ” application-core.yaml μ΄λŸ°μ‹

μ§€λ‚œ ν”Œμ μ—λ„ μ˜ˆμ‹œκ°€ μžˆλ„€μš”. https://github.com/mash-up-kr/MOIT-backend/blob/4e53605f9133c531f2508038c3e92cdd8e6aa569/moit-api/src/main/resources/application.yml#L1-L8

μ–΄λ ΅λ‹€λ©΄ 금주 ν† μš”μΌμ— κ°™μ΄λ³΄μ‹œλ©΄μ„œ μ„ΈνŒ…ν•˜μ‹œμ£ 

xonmin
xonmin reviewed Jun 21, 2024
View reviewed changes
Copy link
Member

@xonmin xonmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ‚˜μ€‘μ— index 생성도 고렀해보면 쒋을 것 κ°™μ•„μš”~

entity/src/main/kotlin/com/mashup/dojo/member/Member.kt Outdated Show resolved Hide resolved
@xonmin xonmin mentioned this pull request Jun 24, 2024
Closed
toychip added 11 commits July 6, 2024 03:38
@toychip
feat: V1 dev, prod ddl (#8)
5f9a4a4
@toychip
refactor: Rename part field to platform (#8)
02cb043
@toychip
refactor: Change default point value in Member class to constant (#8)
9673d14
@toychip
Merge remote-tracking branch 'origin/junhyoung/AddEntity' into junhyo…
0b85952 
…ung/AddEntity
@toychip
feat: add findByValue method to Platform and Gender enums
e76d28d
@toychip
refactor: remove unused entities and enums
d125460
@toychip
refactor: add 'Entity' suffix to Member, Pick, and Question entities
d5fc2dd
@toychip
refactor: replace constructor with factory method in MemberEntity
db9b472
@toychip
refactor: Move enum validation to domain layer and update MemberEntity
d64789f
@toychip
refactor: Embed enums into MemberEntity and remove external enum classes
2d11792
@toychip
refactor: Update MemberEntity to directly use enums and adjust servic…
a0760a4 
…e layer
wonlog-g
wonlog-g reviewed Jul 7, 2024
View reviewed changes
entity/src/main/kotlin/com/mashup/dojo/notification/Notification.kt

@Entity
@Table(name = "notification")
class Notification(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν•΄λ‹Ή ν΄λž˜μŠ€λŠ” id ν•„λ“œ ν•„μš” μ—†λŠ” κ²ƒμΌκΉŒμš”?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μˆ˜μ •ν•΄μ„œ λ°˜μ˜ν–ˆμŠ΅λ‹ˆλ‹€!

wonlog-g
wonlog-g reviewed Jul 7, 2024
View reviewed changes
entity/src/main/kotlin/com/mashup/dojo/MemberEntity.kt
val fullName: String,
@Column(name = "second_initial_name", nullable = false)
val secondInitialName: String,
val profileImageId: String?,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ImageEntityμ™€λŠ” μ—°κ΄€ 관계 μ•ˆν•˜κΈ°λ‘œ ν–ˆμ—ˆλ‚˜μš”..?! 해컀톀 λ•Œ κ΄€λ ¨ν•΄μ„œ μ–˜κΈ°λ‚˜μ™”λ˜ 것 같은데 μ–΄λ–»κ²Œ ν•˜κΈ°λ‘œ ν–ˆμ—ˆμ£ ..?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

음.. ν•΄μ»€ν†€λ•Œ μ΄λ―Έμ§€λŠ” λ”°λ‘œ λ‘κΈ°λ‘œ ν–ˆμ—ˆλ˜ 것 κ°™μ•„μš”. λ‹€μŒ 회의 λ•Œ λ‹€μ‹œ μ–˜κΈ°ν•΄λ³΄κ³  μˆ˜μ •ν•΄μ•Όν•˜λ©΄ μˆ˜μ •ν•˜κ² μŠ΅λ‹ˆλ‹€!

wonlog-g
wonlog-g reviewed Jul 7, 2024
View reviewed changes
entity/src/main/kotlin/com/mashup/dojo/question/QuestionEntity.kt
Comment on lines +34 to +35
questionTypeString: String,
categoryString: String,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 MemberEntity의 Gender와 λ™μΌν•˜κ²Œ Enum으둜 받도둝 μˆ˜μ •ν•  수 μžˆμ„ 것 κ°™μŠ΅λ‹ˆλ‹€!

Copy link
Member Author

@toychip toychip Jul 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ„΅ #38 prμ—μ„œ μˆ˜μ •μ™„λ£Œ ν•΄μ„œ λ¨Έμ§€ν•˜λ©΄ 반영될 것 κ°™μŠ΅λ‹ˆλ‹€~~

@toychip toychip changed the title feat: domain skeleton structure feat: entity skeleton structure Jul 11, 2024
@toychip toychip mentioned this pull request Jul 24, 2024
Closed
3 tasks
@xonmin xonmin closed this Aug 4, 2024
@toychip toychip deleted the junhyoung/AddEntity branch August 12, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wonlog-g wonlog-g wonlog-g left review comments

@xonmin xonmin xonmin left review comments

@yaeoni yaeoni Awaiting requested review from yaeoni yaeoni is a code owner

Assignees

@toychip toychip

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toychip @xonmin @wonlog-g