-
-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds parser option to allow for different storage formats #488
Conversation
Thank you for your contribution and fast response. I'd say you hold on a little, as today I have some minor refactoring upstream which will be conflicting and require a rebase. :) Your changes are well focused and readable. I only have some simple points to consider:
Thanks again... I'd ping as soon I am done. |
Alright, @mathiashsteffensen - feel free to proceed... |
b5e6f29
to
e756994
Compare
…doesn't interfere with subsequent tests
@mathiashsteffensen @mashpie Hi! I'm really interested by this PR. Do you plan to merge it soon? |
yes |
...apply updates, resolve conflicts, retest and review. (maybe complete testing) It's a bit more than "just merging". But Okay, I'll take some time and some coffee "soon". |
@mashpie I was asking as the PR is 3 months old and the initiator start to update the PR also 3 months ago. So, I was asking if the work to merge it was still in progress or on hold... Sorry if my request looked like me asking to do this "ASAP". |
All good. No worries :) it‘s More like: Every task Taking more than some minutes will be lost… These days. So: Thanks for reminding. |
Will close #487
This is my first time contributing to any 'real' OSS, so please don't hold back with your critique :)