Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leaks #121

Merged
merged 3 commits into from
Apr 7, 2022
Merged

Fix leaks #121

merged 3 commits into from
Apr 7, 2022

Conversation

Eitu33
Copy link
Contributor

@Eitu33 Eitu33 commented Apr 6, 2022 •
edited
Loading

@Eitu33 Eitu33 mentioned this pull request Apr 6, 2022
Closed
gterzian
gterzian previously approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@gterzian gterzian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, just one question.

src/execution_impl.rs Show resolved Hide resolved
gterzian
gterzian reviewed Apr 7, 2022
View reviewed changes
src/env.rs Show resolved Hide resolved
This was referenced Apr 7, 2022
Closed
Closed
Closed
@AurelienFT AurelienFT requested a review from gterzian April 7, 2022 06:57
gterzian
gterzian suggested changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@gterzian gterzian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just #121 (comment)

gterzian
gterzian approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@gterzian gterzian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AurelienFT
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Apr 7, 2022

Build succeeded:

@bors bors bot merged commit 4d6e539 into main Apr 7, 2022
@bors bors bot deleted the fix-runtime-leaks branch April 7, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AurelienFT AurelienFT AurelienFT approved these changes

@gterzian gterzian gterzian approved these changes

@damip damip Awaiting requested review from damip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Eitu33 @AurelienFT @gterzian