Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add global config file manager #978

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add global config file manager #978

wants to merge 3 commits into from

Conversation

peterjah
Copy link
Contributor

No description provided.

Copy link
Member

@thomas-senechal thomas-senechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 21.05263% with 30 lines in your changes missing coverage. Please review.

Project coverage is 50.45%. Comparing base (846ab8e) to head (ed1bb55).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
internal/handler/wallet/sign.go 17.64% 26 Missing and 2 partials ⚠️
pkg/assets/dollar.go 0.00% 1 Missing ⚠️
pkg/network/operation.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #978      +/-   ##
==========================================
- Coverage   51.63%   50.45%   -1.18%     
==========================================
  Files          46       46              
  Lines        2750     2735      -15     
==========================================
- Hits         1420     1380      -40     
- Misses       1141     1171      +30     
+ Partials      189      184       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants