Add schematobicep #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update test files, allowed to enum * declare description * reformatting, adding min/max value support * moving creating param line to helper function * trying to handle defaults * fix defaults (strings), still fixing min/max lengths * making test easier to see * fixing default int, prefixing description with sys to avoid collisions * removing notes about defaults * moving comment about description decorator * min/max len string and secure in * min/max len array, default array * moving default array complexity to new helper * default object (almost) need to fix map order * default object working * cleaning up var names * allowed objects working * splitting out functionality to helper for allowed object * refactor pass 1, everything but array/object/allowed optimized * renaming functions, moving them around, fixed arrays * renamed more functions * allowed arrays/objects passing, but need to refactor * remove unneeded test, sloppily solved default objects/arrays * New tests, removing some comments * simplified parseArray & parseObject, just need to handle nest levels * Fixing nest levels after refactoring - Updated renderBicep, parseArray, and parseObject to pass the prefix level back and forth to maintain nesting - Updated test JSON for multi-level nested objects and arrays - Updated test bicep for multi-level nested objects and arrays * Fixed spacing for all but last closing bracket * Fixed deep nesting for objects/arrays * adding error handling, restructured order of functions * Fixes based on suggestions * errors.New -> fmt.Errorf * removing excess error calling * Merging a function, handling some errors
chrisghill
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.