Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for different sources of KeyPair #21

Closed
massenz opened this issue Jan 26, 2022 · 1 comment
Closed

Allow for different sources of KeyPair #21

massenz opened this issue Jan 26, 2022 · 1 comment

Comments

@massenz
Copy link
Owner

massenz commented Jan 26, 2022

Currently KeyMaterialConfiguration assumes that keypair property must be non-null and it has two attributes (priv and pub) which point to respective key material files.

We should allow for different configurations (e.g., a secret-name from AWS Secrets Manager, or Hashicorp Vault) to be used to specify how to retrieve the key material.
massenz added a commit that referenced this issue Oct 29, 2022
@massenz
[#21] Enable fetching KeyPair from AWS SecretsManager
5802aab 
This also somewhat reworks the configuration and logic
so as to simplify adding more sources for secrets
(e.g., Vault, Azure, etc.).
massenz added a commit that referenced this issue Oct 29, 2022
@massenz
[#21] Enable fetching KeyPair from AWS SecretsManager
8d8c2cc 
Moved KeypairReader Bean creation outside of jwt-opa

Library configuration should not get involved in deciding
how and where the keys are loaded.

Also removed the key properties from the token properties.
so as to simplify adding more sources for secrets
(e.g., Vault, Azure, etc.).

Added fake AWS creds to Test GH Action
@massenz
Copy link
Owner Author

massenz commented Oct 29, 2022

Completed with PR #42

@massenz massenz closed this as completed Oct 29, 2022
massenz added a commit that referenced this issue Oct 29, 2022
@massenz
[#21] Enable fetching KeyPair from AWS SecretsManager (#42)
12db937 
Moved KeypairReader Bean creation outside of jwt-opa

Library configuration should not get involved in deciding
how and where the keys are loaded.

Also removed the key properties from the token properties.
so as to simplify adding more sources for secrets
(e.g., Vault, Azure, etc.).

Added fake AWS creds to Test GH Action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Spring Security OPA Integration
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@massenz