DP-22293 Make search page more accessible #1585
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any PRs being created needs a changelog.txt file before being merged into dev. See: Change Log Instructions
Description
Org. filter
Org. filter toggle
For AT users, no contextual information for the org. filter toggle button.
aria-describedby
on the button.<div id="toggle-org-filter" class="ma__visually-hidden" aria-hidden="true">Click the button to show/hide organizataion options for an organization specific search.</div>
.div.toggle-org-filter
with the button witharia-describedby
.aria-hidden="true"
ondiv#toggle-org-filter
ensures it's only announced when the button has focus.TO-DOs:
div#toggle-org-filter
as optional to make the component more versatile. In this particular case, this contextual information is necessary, but it might not in other cases. In case the component is used for other than the search,div#toggle-org-filter
would be generated.Org. filter options (Combobox)
TO-DOs:
label
forinput.react-autosuggest__input
. Thislabel
also serves to provide context info for the option listul.react-autosuggest__suggestions-list
, so don't usearia-label
oninput.react-autosuggest__input
.label
to associate witharia-describedby
onul.react-autosuggest__suggestions-list
.aria-haspopup
value totrue
ondiv.react-autosuggest__container
. The current valuelistbox
is proper for this use, but not supported by most of browsers and benefit only Safari users. For now, usetrue
to be helpful to all users.type
totext
fromsearch
.input.react-autosuggest__input
to associate with thefor
attribute onlabel
.aria-haspopup="true"
toinput.react-autosuggest__input
for the option list.role="listbox"
fromdiv.react-autosuggest__suggestions-container
sinceul.react-autosuggest__suggestions-list
has one. This is a duplicate.aria-describedby
toul.react-autosuggest__suggestions-list
to establish an association with the added label above.Markup is expect to look like:
Filter options (Tabs)
They have
helpful aria-labels
, but not programmatically grouped as a set of options to be recognize by assistive technology.div.ma_search-banner__filter
asaria-label="Search result filter"
.role="tablist"
on the button container,div.ma__tabs
.role="tab"
tobutton.ma__tabs-item
s.aria-controls="search-results"
tobutton.ma__tabs-item
s to show where the buttons' feature affects.No visual changes.
Related Issue / Ticket
Steps to Test
Screenshots
Use something like licecap to capture gifs to demonstrate behaviors.
Additional Notes:
Anything else to add?
Impacted Areas in Application
@todo
Today I learned...