Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F-Droid badge & app links #835

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

F-Droid badge & app links #835

wants to merge 2 commits into from

Conversation

endingisnight
Copy link

@endingisnight endingisnight commented Dec 23, 2024 •
edited
Loading

#831

  • added the F-Droid badge (with many localizastions)
  • added Shitter, Husky and Raccoon
  • made horrible looking links to the app's pages (WHY IS THE ICON SMALLER?!)
    image
  • learned some react :)

@andypiper andypiper self-requested a review December 23, 2024 17:18
@andypiper andypiper self-assigned this Dec 23, 2024
@andypiper
Copy link
Member

As an FYI, I am on vacation for a week or so and may not get to this immediately. I do not intend to add two of these apps (Shitter based on the name which does not align with my goal to keep the project site somewhat professional, and Raccoon based on potential confusion with “for Friendica” being in the title, even if it does work with Mastodon) - per the adding apps section of the contributing guide, we reserve the right not to include every app that exists.

A quick glance at the work you’ve done to add the F-Droid badge looks good but I’ll do a proper review when I’m back and may request changes then. Thanks!

endingisnight added 2 commits December 23, 2024 22:42
Added F-Droid badge to apps
9127b2d 
Now with locales!
If you have a sharp eye you'll notice that the size isn't the same as the others, but it's as close as I'm gonna get.
Added some F-Droid apps
f3d687b
@endingisnight
Copy link
Author

I get not including Shitter (unless they change their name nuclearfog/Shitter#59), but with "Raccoon for Friendica" I'll say that while installed, it shows up as just "Raccoon". So would it be fine to just exclude the "for Friendica" part and still include it?

@andypiper
Copy link
Member

Yes, I think that would be an OK approach.

@andypiper andypiper added enhancement Ideas for improvements apps Issue or PR related to the apps directory labels Dec 24, 2024
@andypiper andypiper linked an issue Dec 24, 2024 that may be closed by this pull request
Add F-Droid badge to apps #831
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andypiper andypiper Awaiting requested review from andypiper

Assignees

@andypiper andypiper

Labels
apps Issue or PR related to the apps directory enhancement Ideas for improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add F-Droid badge to apps
2 participants
@endingisnight @andypiper