Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sample SAML_ACS_URL, SAML_ISSUER #12669

Merged
merged 1 commit into from
Dec 23, 2019

Conversation

orlea
Copy link
Contributor

@orlea orlea commented Dec 23, 2019

The values of SAML_ACS and SAML_ISSUER in the sample .env file are strange.

"http://localhost:3000/auth/auth/saml/callback" should be written as a sample value for SAML_ACS.

In addition, since SAML_ISSUER is a unique value representing the service provider, it is better to enter a domain name unless otherwise specified by IdP.

When actually setting up SAML, the user needs to overwrite it, so it gets confused if strange values are listed.
Thankyou!

@Gargron Gargron merged commit 44f88a3 into mastodon:master Dec 23, 2019
@orlea orlea deleted the Fix-sample-env-files branch December 24, 2019 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants