-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add notifications when a reblogged status has been updated #17404
Conversation
15f9033
to
d11545d
Compare
52417e2
to
b75ecd6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if this notification type warrants all the notification pathways that other notification types use, but I can't see anything in this PR about:
- web push notifications
app/javascript/mastodon/service_worker/web_push_locales.js
,app/javascript/mastodon/service_worker/web_push_notifications.js
,app/controllers/api/web/push_subscriptions_controller.rb
- configuring how and where to show notifications (
app/javascript/mastodon/reducers/settings.js
,app/javascript/mastodon/features/notifications/components/column_settings.js
) - mail notifications
b75ecd6
to
ca4f6ff
Compare
We don't have e-mail notifications for polls or new statuses, and I think it doesn't make sense for this either. I've added the other things. The notification settings are definitely too long now, and have too many things that I wouldn't care about adjusting, but it will do for now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In LocalNotificationWorker
, notifications are skipped if Notification.where(account: receiver, activity: activity).any?
.
This means that update
notifications will be missed if you have a status
(subscription) notification already. Maybe that condition needs changing to include the notification type as well.
5f2ee2d
to
b9f466a
Compare
b9f466a
to
043edf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There is another scenario I'm a bit worried about but I don't have an easy fix to it: suppose you're boosting someone who is silenced (e.g. someone you follow boosted them), and they then edit their post. Because they're silenced and you don't follow them, you don't get the notification.
But on the other hand, someone could be silenced precisely because they do stuff like spam in edits?
Follow-up to #16697
Funded through the BMBF (BMBF Förderkennzeichen: 01IS21S29)