Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix backend compatibility with OpenSSL 3.0 #18449

Merged
merged 3 commits into from
Aug 17, 2022
Merged

Fix backend compatibility with OpenSSL 3.0 #18449

merged 3 commits into from
Aug 17, 2022

Conversation

ClearlyClaire
Copy link
Contributor

@ClearlyClaire ClearlyClaire commented May 17, 2022 •
edited
Loading

Fixes #18206

  • update webauthn and dependencies
  • update webpush

@ClearlyClaire ClearlyClaire changed the title Update to webauthn-ruby fork and bump openssl to 3.0 Fix compatibility with OpenSSL 3.0 May 17, 2022
@ClearlyClaire ClearlyClaire mentioned this pull request May 17, 2022
Closed
@ClearlyClaire
Copy link
Contributor Author

ClearlyClaire commented May 19, 2022 •
edited
Loading

It currently breaks web push notifications because the webpush gem has changed interfaces, and encrypt returns the encrypted payload rather than a Hash with the payload and parameters.

See #18457

@ClearlyClaire ClearlyClaire mentioned this pull request May 20, 2022
Merged
@ClearlyClaire
Copy link
Contributor Author

Reverting to a 0.3.8-based webpush gem fork, Web Push notifications work without further changes.

I have confirmed WebAuthn and WebPush to work on non-OpenSSL 3 systems, and the tests run on an OpenSSL 3 system, although I haven't tested Mastodon in real conditions.

@ClearlyClaire ClearlyClaire marked this pull request as ready for review May 20, 2022 13:35
@ClearlyClaire
Copy link
Contributor Author

Both WebAuthn and Web Push work on OpenSSL 3 systems

204504bySE added a commit to 204504bySE/mastodon that referenced this pull request Jun 4, 2022
@204504bySE
Ruby 3.1対応とOpenSSLのビルドに失敗するやつ対策
4707879 
mastodon/mastodon#18449
204504bySE added a commit to 204504bySE/mastodon that referenced this pull request Jun 5, 2022
@204504bySE
Ruby 3.1対応とOpenSSLのビルドに失敗するやつ対策
473e958 
mastodon/mastodon#18449
@ClearlyClaire ClearlyClaire changed the title Fix compatibility with OpenSSL 3.0 Fix backend compatibility with OpenSSL 3.0 Aug 16, 2022
@Gargron Gargron merged commit 461239d into mastodon:main Aug 17, 2022
@ClearlyClaire ClearlyClaire mentioned this pull request Aug 25, 2022
Closed
@ClearlyClaire ClearlyClaire mentioned this pull request Nov 6, 2022
Closed
@ineffyble ineffyble mentioned this pull request Nov 10, 2022
Closed
dariusk pushed a commit to hometown-fork/hometown that referenced this pull request Nov 11, 2022
@ClearlyClaire @dariusk
Fix backend compatibility with OpenSSL 3.0 (mastodon#18449)
035470e 
* Update webpush to fork with OpenSSL 3 compatibility

* Fix tests with OpenSSL 3.0

* Update webauthn gem to latest release and update dependencies
kadoshita pushed a commit to kadoshita/mastodon that referenced this pull request Nov 19, 2022
@ClearlyClaire @kadoshita
Fix backend compatibility with OpenSSL 3.0 (mastodon#18449)
32ef76c 
* Update webpush to fork with OpenSSL 3 compatibility

* Fix tests with OpenSSL 3.0

* Update webauthn gem to latest release and update dependencies
ClearlyClaire added a commit to ClearlyClaire/mastodon that referenced this pull request Jul 6, 2023
@ClearlyClaire
Fix backend compatibility with OpenSSL 3.0 (mastodon#18449)
ca4ace8 
* Update webpush to fork with OpenSSL 3 compatibility

* Fix tests with OpenSSL 3.0

* Update webauthn gem to latest release and update dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gargron Gargron Gargron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install process fails on Ubuntu 22.04 Jammy Jellyfish
2 participants
@ClearlyClaire @Gargron