Fix design issues with recent react-intl upgrade #25272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `react-intl` upgrade changed the behavior of `Formatted*` components to not wrap translated messages in `span` tags anymore. While this is a pretty good change, it changes the DOM structure and breaks some of Mastodon's styling. Finding all the places where this change breaks the styling may be a better long-term solution, but it's also a much more involved one, so this commit changes `react-intl`'s configuration to always wrap formatted messages in a `span` tag.
This was
linked to
issues
Jun 5, 2023
This was
unlinked from
issues
Jun 5, 2023
renchap
approved these changes
Jun 5, 2023
supernovae
pushed a commit
to Universeodon-com/mastodon
that referenced
this pull request
Jun 7, 2023
skerit
pushed a commit
to 11ways/mastodon
that referenced
this pull request
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
react-intlupgrade changed the behavior ofFormatted*components to not wrap translated messages inspantags anymore. While this is a pretty good change, it changes the DOM structure and breaks some of Mastodon's styling.Finding all the places where this change breaks the styling may be a better long-term solution, but it's also a much more involved one, so this commit changes
react-intl's configuration to always wrap formatted messages in aspantag.See also: https://formatjs.io/docs/react-intl/upgrade-guide-3x#breaking-api-changes