Convert Home timeline components to Typescript #25583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has merge conflicts that must be resolved before it can be merged. |
renchap
force-pushed
the
typescript-home-timeline-components
branch
from
6da5591
to
287ca99
Compare
|
This pull request has resolved merge conflicts and is ready for review. |
renchap
force-pushed
the
typescript-home-timeline-components
branch
from
287ca99
to
5ab7e23
Compare
It now uses hooks, and removed the old-school container component for `<ColumnSettings>`. `onSave` props was not used, so I deleted it. The settings store is not yet properly typed, so I disabled the eslint warnings due to the store using `any`.
renchap
force-pushed
the
typescript-home-timeline-components
branch
from
5ab7e23
to
f118bbc
Compare
ClearlyClaire
approved these changes
Jul 13, 2023
jsgoldstein
pushed a commit
to jsgoldstein/mastodon
that referenced
this pull request
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It now uses hooks, and removed the old-school container component for
<ColumnSettings>.onSaveprops was not used, so I deleted it.The settings store is not yet properly typed, so I disabled the eslint warnings due to the store using
any.