Change light mode to apply CSS variables to the body #30839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the automatic theme, there is no `.theme-mastodon-light`. But we know that the light theme CSS file will only be loaded when the light theme is enabled, so we can set the variables to `body` directly. Also adjusted the alpha on modal background as it was near invisible.
renchap
force-pushed
the
fix-light-mode-css-vars
branch
from
71cd71d to
8fa426f
Compare
Gargron
approved these changes
Jun 25, 2024
nomad-geek
pushed a commit
to dftba-club/mastodon
that referenced
this pull request
Jul 3, 2024
justinwritescode
pushed a commit
to justinwritescode/mastodon
that referenced
this pull request
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the automatic theme, there is no
.theme-mastodon-light. But we know that the light theme CSS file will only be loaded when the light theme is enabled, so we can set the variables tobodydirectly.Also adjusted the alpha on modal background as it was near invisible.