#255 – Collapsable toots! #658
Conversation
|
I imagine this would solve the problem of encountering instances without character limits posting entire articles as well? |
|
Hey @Gargron is this Pull mergable right now? It would help address some of the harassment/spamming concerns that have been brought up in relation to someone making instances for the purpose of spamming. Since a post could not be too long if collapsed. |
|
With the recent influx of new users remarking on the prevalence of bots, I dug through my blocklist- plenty of the ones I've blocked are blocked because they just post immense toots. This pull is exceedingly relevant to new users and will help with harassment in the future; is there any technical reason why this has not been already merged? |
|
This feature is desperately needed. |
| @@ -87,6 +91,11 @@ const StatusContent = React.createClass({ | |||
| this.setState({ hidden: !this.state.hidden }); | |||
| }, | |||
|
|
|||
| handleCollapsedClick (e) { | |||
| e.preventDefault(); | |||
| this.setState({ collapsed: !this.state.collapsed }); | |||
There was a problem hiding this comment.
Is this setting collapsed to !null? Does that result in false? A little unsure of the value flow here.
There was a problem hiding this comment.
It flips the boolean. If collapsed is null, it will set collapsed to true as null is falsey.
However, as handleCollapsedClick only is used when collapsed is not null that case wont happen.
|
Hey, what's the status on getting this merged? |
|
We need it to be reviewed by probably gargron before merging |
|
@marrus-sh thanks for the pull request! Sorry it's bene hanging around with no resolution. It looks like there are a few merge conflicts. Would you be able to pull from latest and review the changes? There are a few CodeClimate issues to resolve too. Then we can ping Gargron and see about getting this merged. Thanks again! |
Fix/stream entry color
Automatically collapses toots in timelines whose text contents are taller than 200px tall, with a button at the bottom to expand. Doesn't look at toots with spoiler/content warnings, so hypothetically if someone really wanted to fill up your feed with long toots they could abuse that. I don't really see that being a problem though.