fix: missing properties (apache#303)

matanolabs · Dec 9, 2024 · 09bd9e1 · 09bd9e1
1 parent 0e8c32e
commit 09bd9e1
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/crates/catalog/hms/src/catalog.rs b/crates/catalog/hms/src/catalog.rs
@@ -176,7 +176,7 @@ impl Catalog for HmsCatalog {
             .await
             .map_err(from_thrift_error)?;
 
-        Ok(Namespace::new(namespace.clone()))
+        Ok(Namespace::with_properties(namespace.clone(), properties))
     }
 
     /// Retrieves a namespace by its identifier.

diff --git a/crates/catalog/hms/tests/hms_catalog_test.rs b/crates/catalog/hms/tests/hms_catalog_test.rs
@@ -264,7 +264,6 @@ async fn test_list_namespace() -> Result<()> {
 async fn test_create_namespace() -> Result<()> {
     let fixture = set_test_fixture("test_create_namespace").await;
 
-    let ns = Namespace::new(NamespaceIdent::new("my_namespace".into()));
     let properties = HashMap::from([
         ("comment".to_string(), "my_description".to_string()),
         ("location".to_string(), "my_location".to_string()),
@@ -279,6 +278,11 @@ async fn test_create_namespace() -> Result<()> {
         ("key1".to_string(), "value1".to_string()),
     ]);
 
+    let ns = Namespace::with_properties(
+        NamespaceIdent::new("my_namespace".into()),
+        properties.clone(),
+    );
+
     let result = fixture
         .hms_catalog
         .create_namespace(ns.name(), properties)