Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrapping readyState checks not necessary #137

Closed
matatk opened this issue Jan 11, 2018 · 1 comment
Closed

Bootstrapping readyState checks not necessary #137

matatk opened this issue Jan 11, 2018 · 1 comment
Assignees
@matatk
Labels
enhancement
Milestone
2.1.1

Comments

@matatk
Copy link
Owner

matatk commented Jan 11, 2018

Both the Chrome developer docs and the MDN docs state that the DOM will be complete when "document_idle" content scripts are run (which is the default).

Therefore, the whole bootstrap() readyState-checking stuff can be removed.

Will add some temporary logging in case the completion of loading of any assets does affect mutations.
@matatk matatk added this to the 2.1.1 milestone Jan 11, 2018
@matatk matatk self-assigned this Jan 11, 2018
@matatk
Copy link
Owner Author

matatk commented Jan 11, 2018 •
edited
Loading

The following code and translation messages should be removable then:

matatk added a commit that referenced this issue Jan 12, 2018
@matatk
Simplify content script bootstrapping (closes #137)
e19e1ee 
* Remove unused translation message.
* Simplify LandmarksFinder API and rename functions for clarity (they
  are getters). This fixes a bug that was there for ages whereby it was
  not calling the function to check the number of landmarks found (in
  checkFocusElement()).
* Vastly simplify the bootstrapping code in content.overall.js.
* Move Logger to content.overall.js from content.pausing.js and
  generalise.
* Remove Logger from content.pausing.js.
matatk added a commit that referenced this issue Jan 12, 2018
@matatk
Simplify content script bootstrapping (closes #137)
b717a89 
* Remove unused translation message.
* Simplify LandmarksFinder API and rename functions for clarity (they
  are getters). This fixes a bug that was there for ages whereby it was
  not calling the function to check the number of landmarks found (in
  checkFocusElement()).
* Vastly simplify the bootstrapping code in content.overall.js.
* Move Logger to content.overall.js from content.pausing.js and
  generalise.
* Remove Logger from content.pausing.js.
* Disconnect observer if content script has been retired (fixes #131).
matatk added a commit that referenced this issue Jan 18, 2018
@matatk
Simplify content script bootstrapping (closes #137)
368596b 
* Remove unused translation message.
* Simplify LandmarksFinder API and rename functions for clarity (they
  are getters). This fixes a bug that was there for ages whereby it was
  not calling the function to check the number of landmarks found (in
  checkFocusElement()).
* Vastly simplify the bootstrapping code in content.overall.js.
* Move Logger to content.overall.js from content.pausing.js and
  generalise.
* Remove Logger from content.pausing.js.
* Disconnect observer if content script has been retired (fixes #131).
@matatk matatk closed this as completed in 5759b72 Jan 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matatk matatk

Labels
enhancement
Projects
None yet
Milestone
2.1.1
Development

No branches or pull requests
1 participant
@matatk