Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invisible controls on dark mode #466

Closed
anevins12 opened this issue Mar 15, 2022 · 3 comments · Fixed by #470
Closed

Invisible controls on dark mode #466

anevins12 opened this issue Mar 15, 2022 · 3 comments · Fixed by #470
Labels
bug
Milestone
next

Comments

@anevins12
Copy link

Using a darkmode theme on Chrome results in white text on white background
Untitled
@matatk matatk transferred this issue from matatk/page-structural-semantics-scanner-tests Mar 27, 2022
@matatk
Copy link
Owner

matatk commented Mar 28, 2022

Thanks for this @anevins12. I was able to reproduce it.

@matatk matatk added the bug label Mar 28, 2022
@matatk matatk added this to the next milestone Mar 28, 2022
matatk added a commit that referenced this issue Mar 29, 2022
@matatk
fix: Correct dark mode colours in DevTools panel
154c6a1 
Switch to using prefers-color-scheme.

Fixes #466
@matatk
Copy link
Owner

matatk commented Mar 29, 2022

Thanks for reporting. I've fixed this (and it will soon be, though isn't yet, in an official release). Turns out it was affecting Edge and Opera too. I was using devtools.panels.themeName and the browser.devtools.panels.onThemeChanged event to detect when the DevTools theme changed, but have switched to using prefers-color-scheme directly in the DevTools panel's CSS now. Not sure if back when I first implemented this, the media query wasn't well-supported, but it certainly is now.

@matatk matatk mentioned this issue Mar 29, 2022
Merged
matatk added a commit that referenced this issue Mar 30, 2022
@matatk
fix: Correct dark mode colours in DevTools panel (#470)
b59b846 
Switch to using prefers-color-scheme.

Fixes #466
@matatk
Copy link
Owner

matatk commented Apr 1, 2022

2.11.1 has been released and contains the fix for this bug. It's available in Firefox and Chrome now; Opera and Edge should follow in several days, after review. Thanks again for your report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
next
Development

Successfully merging a pull request may close this issue.

fix: Correct dark mode colours in DevTools panel matatk/landmarks
2 participants
@matatk @anevins12