Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Robust, customisable borders with labels #158

Merged
merged 23 commits into from
May 8, 2018
Merged

Robust, customisable borders with labels #158

merged 23 commits into from
May 8, 2018

Conversation

matatk
Copy link
Owner

@matatk matatk commented May 8, 2018

@matatk
npm
7660fbd 
* Forgot to bump version in package-lock.json; oops.
* npm 6 tweaks.
@matatk
Borders made out of <div>s
8645504 
* Make border elements so that they can be positioned on top of all
  other elements.
* Factor out landmarkName() to a separate file as it is used to provide
  a label for the border effect.
* Update the manifest and injector script in line with this new file.
* Make the functions that returned elements now return the role and
  label too (so that they can be used in the label for the border).
* Try to ignore changes to the DOM due to adding our border elements.
@matatk
Sort out borders and mutations and stuff
fd875c7 
* Take out code that ignored border mutations, as they should be ignored by the new ignoring mechanism.
* Provide a mechanism for ignoring border related mutations (ask the ElementFocuser if it just made changes).
* Rename variables for clarity.
* Reinstate the line that allowed the currently-selected landmark to be tracked across landmark updates.
* Fix moving to the main landmark.
@matatk
Minor tidying
c4213fb 
* Improve function name.
* Improve variable names and spacing.
@matatk
Border removal robustness; Settings
1e154f0 
* Cancel the timeout that removes the border if another element is
  highlighted.
* A dictionary was not necessary for storing element borders as there is
  only one!  (There may well be more than one later, when all are added at
  once, but that is getting ahead of oneself.)
* Add an option for border colour.
* Add a 'defaults.js' file to store options.

The injection and number of support scripts is a bit big now - time to
consider rollup or similar?
@matatk
No longer need outline manual test page.
daeb48c
@matatk
Preferences
714510d 
* Add a setting for border label font size.
* Simplify the handling of defaults.
@matatk
Bump package-lock.json package version
6919411
@matatk
Label font colour option; Styling
ebe02f5 
* Add a label font colour option.
* Apply the "browser-style" class as per MDN advice
  (<https://developer.mozilla.org/en-US/Add-ons/WebExtensions/user_interface/Browser_styles>
  —was missing the class on parents of <input>s).
@matatk
Change default border colour to green
9fa6012
@matatk
Neaten up options layout using CSS grid
7470b24 
The "(pixels)" bit wraps in Chrome, but not Firefox.
@matatk
Don't inject the content script into special pages
9b1f83a
@matatk
Add resize handling to borders
6ca27e8
@matatk
Options changes handling; Build speed-up
8643541 
* Add a build:all:quick script (no cleaning or testing done first).
* Fix a bug in how options changes for the logger were not handled correctly.
* Handle options changes in the focuser in the same way as in the logger.
@matatk
Adjust padding around border label
bd2f010
@matatk
Add test for contrast ratio
7456945 
These will be used to determine the appropriate label font colour.
@matatk
Contrast test; TODO
45f90d6 
* Add tests for contrast checking.
* Add a function to work out whether the label should be black or white for a given border colour (not yet wired up).
* Add a TODO for tidying up function definition in focuser.
@matatk
Remove manual border label font colour option
0d52be1 
Instead it works it out (black or white, at least) :-).
@matatk
Change default border colour to pink
3185512
@matatk
Documentation :-)
859d8a9
@matatk
PR number
8673f61
@matatk
Account for font size and boldness in contrast ratio calculations
5ebabdf
@matatk
Neaten up definition of removeBorderOnCurrentlySelectedElement()
1204c4e
@matatk matatk merged commit 4b2e487 into master May 8, 2018
@matatk matatk deleted the robust-borders branch May 8, 2018 19:39
matatk added a commit that referenced this pull request May 10, 2018
@matatk
Specify unused relevant CSS; Remove data attribute
2b93603 
This resets various CSS properties that are not explicitly used by the
border and label elements, in case the page does set them. It also
removes a redundant data attribute that was used early on in #158 but a
better way was found to ignore the borders so it's no longer needed.
@matatk matatk mentioned this pull request May 10, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is there a way to make the CSS outline always visible? Labelling of Landmarks
1 participant
@matatk