Sidebar #188
Merged
Sidebar #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added a sidebar (just the same popup). * Add option to use the popup (default) or sidebar. * Problems with activating popup/sidebar; needs work.
* Allow sidebar to react when the user moves between tabs. * Allow sidebar to react when the content script has finished loading. Currently this still involves the "popup" asking for landmarks and, if it is running as a sidebar, encountering an error, as the sidebar loads before the content script runs, but this is imperceptible to the user and so-far appears the best solution. * Style: wrap inline object literals with inner spaces (need to find an ESLint rule for this...)
* It mostly works. Opera does not have open() nor close() as well as isOpen(). This will need refactoring when moving to rollup or similar as it will be much cleaner then. * Move the sidebar_action keys in the manifests to next to the browser_action keys for readability.
* Remove the HTML for the UI options from !Firefox !Opera. * Fix output of error messages from build script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow landmarks to be displayed in a sidebar on Firefox and Opera.
This almost completely addresses #180 but needs refinement which will come when #189 is done.