This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
Implement Performance Tracking (Fixes #130) #182
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To make sure that each additional feature added to Spacefish doesn't result in a slower and worse experience for the user. Also to make sure that we keep our code as efficient + quick as possible and keep the actual prompt section as light as possible.
If we get this working, we could upstream as much as possible to Spaceship. (I'm not sure if Zsh/bash has a similar way to profile functions in the same way that
fish -p
does.)To-do:
(master vs <new_branch>)
This pull requests adds +20ms on average to prompt initialisation. The slowest lines of code in the diff are <insert output>.
Motivation and Context
Closes #130.
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Checklist: