This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
Add configs for prompt character #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matchai
suggested changes
Feb 4, 2018
fish_prompt.fish
Outdated
| # Set defaults | ||
| set -q SPACEFISH_CHAR_PREFIX "" | ||
| set -q SPACEFISH_CHAR_SYMBOL ➜ | ||
| set -q SPACEFISH_CHAR_SUFFIX " " |
There was a problem hiding this comment.
I've created the __sf_util_set_default fish function that allows you to not override user configs in config.fish.
Could you please swap out these set -q with it?
|
|
||
| You have ability to customize or disable specific elements of Spacefish. All options must be overridden in your `config.fish`. | ||
|
|
||
| Colors for sections can be [basic colors](https://fishshell.com/docs/current/commands.html#set_color) or [color codes](https://upload.wikimedia.org/wikipedia/commons/1/15/Xterm_256color_chart.svg). |
There was a problem hiding this comment.
I went ahead and swapped the docs being linked to with fish-specific ones.
Let me know if you have any questions 😄
fish_prompt.fish
Outdated
| @@ -12,6 +17,6 @@ function fish_prompt | |||
| __sf_section_dir cyan $brwhite magenta red | |||
| __sf_section_exec_time $brwhite yellow | |||
| echo | |||
| echo -e -n -s (set_color $arrow_color) "➜ " | |||
| echo -e -n -s (set_color $arrow_color) "$SPACEFISH_CHAR_PREFIX$SPACEFISH_CHAR_SYMBOL$SPACEFISH_CHAR_SUFFIX" | |||
There was a problem hiding this comment.
I would now consider moving the arrow prompt into a separate "char section" fish function, like I have for the other sections to parallel the char section in spaceship.
Feel free to create a new fish function for that, otherwise I'll move this stuff over in the next update.
matchai
approved these changes
Feb 4, 2018
|
LGTM! 👍 |
12 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some configuration options. To use them, add the following to your
config.fish: