You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
A recent change in Laravel Scout v8.6.1 moved commands to be registered during boot(): laravel/scout#453
This causes the default scout:import to be used rather than this service, regardless of the order of ServiceProviders.
To Reproduce
Steps to reproduce the behavior:
Upgrade to Laravel Scout v8.6.1
Run command php artisan scout:import 'App\YourModel'
Artisan will run the default import command instead of this package's command
Expected behavior
This service should override the scout:import command
Additional context
I believe a simple fix should be move to move the call to registerCommands() inside of boot() instead of register(), however I don't know what the impact would be to versions of Scout prior to v8.6.1. My guess is it would be okay as boot() always occurs after register() so it would still properly override. Some testing against different versions of v8 may be required or upping the minimum version dependency to laravel\scout ^8.6.1.
Version
Versions of Laravel, Scout, and the package.
The text was updated successfully, but these errors were encountered:
Describe the bug
A recent change in Laravel Scout v8.6.1 moved commands to be registered during boot():
laravel/scout#453
This causes the default scout:import to be used rather than this service, regardless of the order of ServiceProviders.
To Reproduce
Steps to reproduce the behavior:
php artisan scout:import 'App\YourModel'
Expected behavior
This service should override the scout:import command
Additional context
I believe a simple fix should be move to move the call to
registerCommands()
inside ofboot()
instead ofregister()
, however I don't know what the impact would be to versions of Scout prior to v8.6.1. My guess is it would be okay asboot()
always occurs afterregister()
so it would still properly override. Some testing against different versions of v8 may be required or upping the minimum version dependency to laravel\scout ^8.6.1.Version
Versions of Laravel, Scout, and the package.
The text was updated successfully, but these errors were encountered: