Implemented link to astroneer wiki #6
Conversation
Fixing typo within english language
Remove not needed comment
Some improvements, qol changes and added wiki link
There was a problem hiding this comment.
Thanks for your contribution. First, I see that your pull request contains a lot of commits and modifications that are not related to the feature you actually want to add:
- updates of the syntax of CSS/Typescript code
- unrelated addition or updates of files (package.json, package-lock.json, .node-version)
- extra spaces or lines in different files
- update of the size of the icons
Could you please clean your request, keeping only what is related to the topic? You should also run the command npm run lint before submitting the request.
Regarding the feature it-self, you are programmatically generating the link to the wiki. It's not guaranteed that the IDs from the database match the one on the wiki. Are you sure it's reliable?
| @@ -111,6 +111,29 @@ export const Things = { | |||
| } | |||
| return Labels.Localize(thing.label); | |||
| }, | |||
| DrawWiki: (thing: Thing): HTMLElement => { | |||
| const wiki = document.createFullElement('div', {class: 'wiki'}); | |||
| const link = document.createFullElement('a', {href: Router.GetWikiUrl(thing), target: '_blank'}); | |||
There was a problem hiding this comment.
"target: blank" is very bad for the user experience
There was a problem hiding this comment.
Open for discussion, for me it makes no sense to lose focus of the companion app.
|
Thanks for the feedback, I let the linter run but nothing changed. The changes are the default settings Vscode should pickup from your linting file. |
As a user of the app, I am a little lazy and would like to be able to check on details of certain items, planets and so on. In order to be able to achieve that, I added a wiki link drawer, which adds an tool tip in the ingame style, which allows a click out.