Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional documentation for code highlighting #406

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Conversation

matalo33
Copy link
Contributor

@matalo33 matalo33 commented Jun 1, 2020

Fixes #283

@matalo33 matalo33 added the meta Issues related to the management of the theme label Jun 1, 2020
@matalo33 matalo33 added this to the v2.5.0 milestone Jun 1, 2020
@matalo33 matalo33 merged commit 6dea56b into master Jun 1, 2020
@kyeotic
Copy link

kyeotic commented Jun 1, 2020

@matalo33 I dont understand how this fixes #283. That issue indicates that the problem is with the highlight pack itself not containing common languages, but the documentation you added doubles down on the confusion that it does contain the common languages. Has the highlight pack been updated by another PR? If not, the documentation solution is to explain to users how to generate and override the highlight pack with one that contains languages like JS

@matalo33 matalo33 deleted the fix-283 branch June 1, 2020 16:35
@matalo33
Copy link
Contributor Author

matalo33 commented Jun 1, 2020

The highlight.pack.js was updated today in commit 8349d61. Admittedly it should have been in this PR but I included it in the wrong one by accident.

As I understand #283 it's stating there are missing common languages (now fixed) and that the docs to support additional languages was missing (also now fixed).

Did I miss anything else?

@kyeotic
Copy link

kyeotic commented Jun 1, 2020

Nope, sounds good. The highlight pack update was the missing piece

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues related to the management of the theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax Highlighting not working for JS and Docs don't Document Why
2 participants