Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blacklist some session-specific variables (with corrected author name) #303

Closed
wants to merge 1 commit into from

Conversation

raveit65
Copy link
Member

@raveit65 raveit65 commented May 5, 2023

Same as #282
But with corrected author name from gnome.

Things like XDG_SESSION_ID should not be uploaded to the environment.
For example this is broken currently:

  1. SSH to your machine
  2. Log in to MATE Shell
  3. Log out
  4. Log in again
  5. Lock the screen
  6. Try to unlock

You can't, and this is because the XDG_SESSION_ID from the first session
(step 2) has leaked through to the second one (step 4), and so MATE
Shell is listening to the logind UnlockSession signal for the wrong
session. The SSH session established in step 1 serves to keep the
systemd --user instance alive, so that the state is not torn down
between logins.

Patch from GNOME by Iain Lane iainl@gnome.org

@raveit65 raveit65 changed the title Blacklist some session-specific variables (with correct author name) Blacklist some session-specific variables (with corrected author name) May 5, 2023
@raveit65 raveit65 requested a review from a team May 5, 2023 17:35
@zhuyaliang
Copy link
Member

@raveit65 What should I do to Log in to MATE Shell and Log out

@raveit65
Copy link
Member Author

raveit65 commented May 6, 2023

I could never reproduced the original issue in bug report, (impossible to unlock the session after the session was locked).
But the problem is that after log out the session is still active.

[rave@mother ~]$ loginctl list-sessions
SESSION  UID USER SEAT  TTY  
      2 1000 rave seat0 
      5 1000 rave seat0 
      6 1000 rave       pts/7
      8 1000 rave seat0 

4 sessions listed.
[rave@mother ~]$ 

After every new login from login-manager (lightdm) a new session will create but the old one is still there.
But sadly this patch does fix nothing here with my fedora box.
Maybe it's different with debian or archLinux.
Any way i will close this PR.

@raveit65 raveit65 closed this May 6, 2023
@raveit65
Copy link
Member Author

raveit65 commented May 6, 2023

@raveit65 What should I do to Log in to MATE Shell and Log out

I think login from Login-manager is meant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants