Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 04 add tests #15

Merged
merged 8 commits into from
May 2, 2020
Merged

Fix 04 add tests #15

merged 8 commits into from
May 2, 2020

Conversation

mateimicu
Copy link
Owner

No description provided.

@mateimicu mateimicu linked an issue May 2, 2020 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 2, 2020

Codecov Report

Merging #15 into master will increase coverage by 2.38%.
The diff coverage is 45.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
+ Coverage   39.30%   41.68%   +2.38%     
==========================================
  Files           9        9              
  Lines         374      379       +5     
==========================================
+ Hits          147      158      +11     
+ Misses        211      204       -7     
- Partials       16       17       +1     
Impacted Files Coverage Δ
cmd/aws_update.go 53.76% <42.10%> (-1.92%) ⬇️
cmd/aws_list.go 94.44% <100.00%> (ø)
internal/regions.go 68.18% <0.00%> (+45.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5c5d4d...faf3e23. Read the comment docs.

@mateimicu mateimicu force-pushed the fix-04-add-tests branch from c81f13f to 750ba39 Compare May 2, 2020 00:57
@mateimicu mateimicu force-pushed the fix-04-add-tests branch 2 times, most recently from 8a1d7dd to cf937af Compare May 2, 2020 01:39
* for GetRegions
* fileExists
Add test foest for GetRegions
@mateimicu mateimicu force-pushed the fix-04-add-tests branch from cf937af to faf3e23 Compare May 2, 2020 01:40
@mateimicu mateimicu merged commit 56fdf61 into master May 2, 2020
@mateimicu mateimicu deleted the fix-04-add-tests branch May 2, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add tests for important parts and expecially some integration tests
1 participant